Hi Sebastian,
CC TI K3
On Wed, Nov 8, 2023 at 8:29 PM Sebastian Fricke
<[email protected]> wrote:
> From: Robert Beckett <[email protected]>
>
> Add bindings for the wave5 chips&media codec driver
>
> Signed-off-by: Robert Beckett <[email protected]>
> Signed-off-by: Dafna Hirschfeld <[email protected]>
> Signed-off-by: Sebastian Fricke <[email protected]>
Thanks for your patch, which is now commit de4b9f7e371a5384
("dt-bindings: media: wave5: add yaml devicetree bindings")
in media/master.
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
> @@ -0,0 +1,61 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/cnm,wave521c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Chips&Media Wave 5 Series multi-standard codec IP
> +
> +maintainers:
> + - Nas Chung <[email protected]>
> + - Jackson Lee <[email protected]>
> +
> +description:
> + The Chips&Media WAVE codec IP is a multi format video encoder/decoder
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - ti,k3-j721s2-wave521c
This is the only compatible value defined which contains both "k3"
and "j72*". I assume the "k3-" part should be dropped?
> + - const: cnm,wave521c
> +
This also applies to the driver added in commit 9707a6254a8a6b97
("media: chips-media: wave5: Add the v4l2 layer") in media/master.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On 11:27-20231128, Geert Uytterhoeven wrote:
> Hi Sebastian,
>
> CC TI K3
Thanks for looping us in Geert.
[...]
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - ti,k3-j721s2-wave521c
>
> This is the only compatible value defined which contains both "k3"
> and "j72*". I assume the "k3-" part should be dropped?
Correct - we have not been using architecture prefix such as k3- in
compatibles for any other peripheral and that lines up with DT spec[1]
$ git grep ti, Documentation/|grep compatible|grep yaml|cut -d ':' -f2|grep k3-
is empty.
I have for asked this to be cleared up[2] before I can pick the dts changes
corresponding to the binding.. I will wait for the bindings to hit linus
master prior to looking at the dts changes.
[1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.4
[2] https://lore.kernel.org/all/20231201062427.6fw5gn2zgkkurv4q@shadow/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D