PM and PM_GENERIC_DOMAINS configs are required for RZ/N1 SOCs.
Without these configs, the clocks used by the PCI bridge are not
enabled and so accessing the devices leads to a kernel crash:
[ 0.832958] Unhandled fault: external abort on non-linefetch (0x1008) at 0x90b5f848
Select PM and PM_GENERIC_DOMAINS for ARCH_RZN1
Signed-off-by: Herve Codina <[email protected]>
---
drivers/soc/renesas/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index fdc99a05a7e0..15fff5632167 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -47,6 +47,8 @@ config ARCH_RZG2L
config ARCH_RZN1
bool
+ select PM
+ select PM_GENERIC_DOMAINS
select ARM_AMBA
if ARM && ARCH_RENESAS
--
2.35.1
On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <[email protected]> wrote:
> PM and PM_GENERIC_DOMAINS configs are required for RZ/N1 SOCs.
> Without these configs, the clocks used by the PCI bridge are not
> enabled and so accessing the devices leads to a kernel crash:
> [ 0.832958] Unhandled fault: external abort on non-linefetch (0x1008) at 0x90b5f848
>
> Select PM and PM_GENERIC_DOMAINS for ARCH_RZN1
>
> Signed-off-by: Herve Codina <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v5.19.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
On Wed, 27 Apr 2022 16:58:07 +0200
Geert Uytterhoeven <[email protected]> wrote:
> On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <[email protected]> wrote:
> > PM and PM_GENERIC_DOMAINS configs are required for RZ/N1 SOCs.
> > Without these configs, the clocks used by the PCI bridge are not
> > enabled and so accessing the devices leads to a kernel crash:
> > [ 0.832958] Unhandled fault: external abort on non-linefetch (0x1008) at 0x90b5f848
> >
> > Select PM and PM_GENERIC_DOMAINS for ARCH_RZN1
> >
> > Signed-off-by: Herve Codina <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> i.e. will queue in renesas-devel for v5.19.
>
I plan to send a v4 of this series.
As this patch (4/8) and the following one (5/8) will be
queued for v5.19, I plan to remove them from the v4 version
of the series.
Is that ok for you or do you prefer to still have them
in v4 ?
Regards,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Hi Hervé,
On Thu, Apr 28, 2022 at 11:15 AM Herve Codina <[email protected]> wrote:
> On Wed, 27 Apr 2022 16:58:07 +0200
> Geert Uytterhoeven <[email protected]> wrote:
> > On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <[email protected]> wrote:
> > > PM and PM_GENERIC_DOMAINS configs are required for RZ/N1 SOCs.
> > > Without these configs, the clocks used by the PCI bridge are not
> > > enabled and so accessing the devices leads to a kernel crash:
> > > [ 0.832958] Unhandled fault: external abort on non-linefetch (0x1008) at 0x90b5f848
> > >
> > > Select PM and PM_GENERIC_DOMAINS for ARCH_RZN1
> > >
> > > Signed-off-by: Herve Codina <[email protected]>
> >
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
> > i.e. will queue in renesas-devel for v5.19.
>
> I plan to send a v4 of this series.
>
> As this patch (4/8) and the following one (5/8) will be
> queued for v5.19, I plan to remove them from the v4 version
> of the series.
>
> Is that ok for you or do you prefer to still have them
> in v4 ?
As these two patches are not strictly related to adding PCI support,
but they are dependencies, I will queue them separately. Hence you
do not need to include them in v5.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Geert,
On Thu, 28 Apr 2022 11:22:35 +0200
Geert Uytterhoeven <[email protected]> wrote:
> Hi Hervé,
>
> On Thu, Apr 28, 2022 at 11:15 AM Herve Codina <[email protected]> wrote:
> > On Wed, 27 Apr 2022 16:58:07 +0200
> > Geert Uytterhoeven <[email protected]> wrote:
> > > On Fri, Apr 22, 2022 at 2:09 PM Herve Codina <[email protected]> wrote:
> > > > PM and PM_GENERIC_DOMAINS configs are required for RZ/N1 SOCs.
> > > > Without these configs, the clocks used by the PCI bridge are not
> > > > enabled and so accessing the devices leads to a kernel crash:
> > > > [ 0.832958] Unhandled fault: external abort on non-linefetch (0x1008) at 0x90b5f848
> > > >
> > > > Select PM and PM_GENERIC_DOMAINS for ARCH_RZN1
> > > >
> > > > Signed-off-by: Herve Codina <[email protected]>
> > >
> > > Reviewed-by: Geert Uytterhoeven <[email protected]>
> > > i.e. will queue in renesas-devel for v5.19.
> >
> > I plan to send a v4 of this series.
> >
> > As this patch (4/8) and the following one (5/8) will be
> > queued for v5.19, I plan to remove them from the v4 version
> > of the series.
> >
> > Is that ok for you or do you prefer to still have them
> > in v4 ?
>
> As these two patches are not strictly related to adding PCI support,
> but they are dependencies, I will queue them separately. Hence you
> do not need to include them in v5.
Perfect.
Thanks,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com