2021-11-03 17:33:03

by Prabhakar Mahadev Lad

Subject: [PATCH 1/3] dt-bindings: serial: renesas,scif: Make resets as a required property

Make "resets" as required property for RZ/G2L. On RZ/G2L the devices
should be explicitly pulled out of reset for this reason make "resets"
as required property.

Signed-off-by: Lad Prabhakar <[email protected]>
Reviewed-by: Biju Das <[email protected]>
---
Documentation/devicetree/bindings/serial/renesas,scif.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
index 6b8731f7f2fb..df052dec7e63 100644
--- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
+++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
@@ -151,6 +151,7 @@ if:
compatible:
contains:
enum:
+ - renesas,scif-r9a07g044
- renesas,rcar-gen2-scif
- renesas,rcar-gen3-scif
then:
--
2.17.1

2021-11-08 20:34:50

by Geert Uytterhoeven

Subject: Re: [PATCH 1/3] dt-bindings: serial: renesas,scif: Make resets as a required property

On Wed, Nov 3, 2021 at 6:31 PM Lad Prabhakar
<[email protected]> wrote:
> Make "resets" as required property for RZ/G2L. On RZ/G2L the devices
> should be explicitly pulled out of reset for this reason make "resets"
> as required property.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> Reviewed-by: Biju Das <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

> --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> @@ -151,6 +151,7 @@ if:
> compatible:
> contains:
> enum:
> + - renesas,scif-r9a07g044
> - renesas,rcar-gen2-scif
> - renesas,rcar-gen3-scif

People might prefer alphabetical sort order...

> then:

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-11-09 07:26:45

by Lad, Prabhakar

Subject: Re: [PATCH 1/3] dt-bindings: serial: renesas,scif: Make resets as a required property

Hi Geert,

Thank you for the review.

On Mon, Nov 8, 2021 at 4:29 PM Geert Uytterhoeven <[email protected]> wrote:
>
> On Wed, Nov 3, 2021 at 6:31 PM Lad Prabhakar
> <[email protected]> wrote:
> > Make "resets" as required property for RZ/G2L. On RZ/G2L the devices
> > should be explicitly pulled out of reset for this reason make "resets"
> > as required property.
> >
> > Signed-off-by: Lad Prabhakar <[email protected]>
> > Reviewed-by: Biju Das <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml
> > @@ -151,6 +151,7 @@ if:
> > compatible:
> > contains:
> > enum:
> > + - renesas,scif-r9a07g044
> > - renesas,rcar-gen2-scif
> > - renesas,rcar-gen3-scif
>
> People might prefer alphabetical sort order...
>
My intention was to keep the generic ones at the end as we do for
compatible property. Let me know if you still want me to change it.

Cheers,
Prabhakar

> > then:
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds