2014-04-10 17:47:01

by Geert Uytterhoeven

Subject: [PATCH] staging: r8723au: Add missing initialization of change_inx in sort algorithm

drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function ‘WMMOnAssocRsp23a’:
drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: ‘change_inx’ may be used uninitialized in this function

Depending on the uninitialized data on the stack, the array may not be
sorted correctly.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
index 0dfcfbce3b52..a4361bb93865 100644
--- a/drivers/staging/rtl8723au/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
@@ -681,7 +681,7 @@ void WMMOnAssocRsp23a(struct rtw_adapter *padapter)
inx[0] = 0; inx[1] = 1; inx[2] = 2; inx[3] = 3;

if (pregpriv->wifi_spec == 1) {
- u32 j, tmp, change_inx;
+ u32 j, tmp, change_inx = false;

/* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */
for (i = 0; i < 4; i++) {
--
1.7.9.5

2014-04-10 18:01:27

by Larry Finger

Subject: Re: [PATCH] staging: r8723au: Add missing initialization of change_inx in sort algorithm

On 04/10/2014 12:46 PM, Geert Uytterhoeven wrote:
> drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function ‘WMMOnAssocRsp23a’:
> drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: ‘change_inx’ may be used uninitialized in this function
>
> Depending on the uninitialized data on the stack, the array may not be
> sorted correctly.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---

Acked-by: Larry Finger <[email protected]>

Geert,

Thanks for this. I wonder why my gcc on x86_64 did not flag this problem.

Larry

> drivers/staging/rtl8723au/core/rtw_wlan_util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> index 0dfcfbce3b52..a4361bb93865 100644
> --- a/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> +++ b/drivers/staging/rtl8723au/core/rtw_wlan_util.c
> @@ -681,7 +681,7 @@ void WMMOnAssocRsp23a(struct rtw_adapter *padapter)
> inx[0] = 0; inx[1] = 1; inx[2] = 2; inx[3] = 3;
>
> if (pregpriv->wifi_spec == 1) {
> - u32 j, tmp, change_inx;
> + u32 j, tmp, change_inx = false;
>
> /* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */
> for (i = 0; i < 4; i++) {
>

2014-04-10 18:05:36

by Geert Uytterhoeven

Subject: Re: [PATCH] staging: r8723au: Add missing initialization of change_inx in sort algorithm

Hi Larry,

On Thu, Apr 10, 2014 at 8:01 PM, Larry Finger <[email protected]> wrote:
> On 04/10/2014 12:46 PM, Geert Uytterhoeven wrote:
>>
>> drivers/staging/rtl8723au/core/rtw_wlan_util.c: In function
>> ‘WMMOnAssocRsp23a’:
>> drivers/staging/rtl8723au/core/rtw_wlan_util.c:684: warning: ‘change_inx’
>> may be used uninitialized in this function
>>
>> Depending on the uninitialized data on the stack, the array may not be
>> sorted correctly.
>>
>> Signed-off-by: Geert Uytterhoeven <[email protected]>
>> ---
>
> Acked-by: Larry Finger <[email protected]>
>
> Geert,
>
> Thanks for this. I wonder why my gcc on x86_64 did not flag this problem.

Because it's too new?

Several warnings were disabled in more recent versions of gcc (still
using 4.1.2 for m68k here ;-) due to too many false positives.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds