Replace `reg_data` access with the official wrapper. The field is going
away soon.
Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Michał Mirosław <[email protected]>
---
drivers/pinctrl/renesas/pfc-sh73a0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/renesas/pfc-sh73a0.c b/drivers/pinctrl/renesas/pfc-sh73a0.c
index ca5adf2095be..41587233aa44 100644
--- a/drivers/pinctrl/renesas/pfc-sh73a0.c
+++ b/drivers/pinctrl/renesas/pfc-sh73a0.c
@@ -4024,7 +4024,7 @@ static const struct pinmux_irq pinmux_irqs[] = {
static void sh73a0_vccq_mc0_endisable(struct regulator_dev *reg, bool enable)
{
- struct sh_pfc *pfc = reg->reg_data;
+ struct sh_pfc *pfc = rdev_get_drvdata(reg);
void __iomem *addr = pfc->windows[1].virt + 4;
unsigned long flags;
u32 value;
@@ -4057,7 +4057,7 @@ static int sh73a0_vccq_mc0_disable(struct regulator_dev *reg)
static int sh73a0_vccq_mc0_is_enabled(struct regulator_dev *reg)
{
- struct sh_pfc *pfc = reg->reg_data;
+ struct sh_pfc *pfc = rdev_get_drvdata(reg);
void __iomem *addr = pfc->windows[1].virt + 4;
unsigned long flags;
u32 value;
--
2.39.2
Hi Michal,
On Wed, May 1, 2024 at 1:16 PM Michał Mirosław <[email protected]> wrote:
> Replace `reg_data` access with the official wrapper. The field is going
> away soon.
Thanks for your patch!
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
I am not sure these tags are needed, as the issue is not present in
any tree yet?
> Signed-off-by: Michał Mirosław <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
Do you want me to pick this up (for v6.11), or do you want to queue
this with the other patches from the series that removes reg_data?
Please let me know.
In case of the latter:
Acked-by: Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Thu, May 02, 2024 at 09:56:39AM +0200, Geert Uytterhoeven wrote:
> Hi Michal,
>
> On Wed, May 1, 2024 at 1:16 PM Michał Mirosław <[email protected]> wrote:
> > Replace `reg_data` access with the official wrapper. The field is going
> > away soon.
>
> Thanks for your patch!
>
> > Reported-by: kernel test robot <[email protected]>
> > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> I am not sure these tags are needed, as the issue is not present in
> any tree yet?
>
> > Signed-off-by: Michał Mirosław <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Do you want me to pick this up (for v6.11), or do you want to queue
> this with the other patches from the series that removes reg_data?
> Please let me know.
> In case of the latter:
> Acked-by: Geert Uytterhoeven <[email protected]>
If you're ok with it going through the regulator tree, then I guess it
would be easier to manage as the series would build without observing
additional dependencies.
Best Regards
Michał Mirosław