2024-06-03 03:02:27

by Jeff Johnson

[permalink] [raw]
Subject: [PATCH] auxdisplay: linedisp: add missing MODULE_DESCRIPTION() macro

make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/line-display.o

Add the missing invocation of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/auxdisplay/line-display.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/line-display.c b/drivers/auxdisplay/line-display.c
index e2b546210f8d..83c94e6c4df9 100644
--- a/drivers/auxdisplay/line-display.c
+++ b/drivers/auxdisplay/line-display.c
@@ -388,4 +388,5 @@ void linedisp_unregister(struct linedisp *linedisp)
}
EXPORT_SYMBOL_NS_GPL(linedisp_unregister, LINEDISP);

+MODULE_DESCRIPTION("Character line display core support");
MODULE_LICENSE("GPL");

---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-drivers-auxdisplay-linedisp-2a12960a1892



2024-06-03 07:54:11

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] auxdisplay: linedisp: add missing MODULE_DESCRIPTION() macro

On Mon, Jun 3, 2024 at 5:02 AM Jeff Johnson <[email protected]> wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/line-display.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2024-06-03 19:48:10

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] auxdisplay: linedisp: add missing MODULE_DESCRIPTION() macro

On Mon, Jun 03, 2024 at 09:53:40AM +0200, Geert Uytterhoeven wrote:
> On Mon, Jun 3, 2024 at 5:02 AM Jeff Johnson <[email protected]> wrote:
> > make allmodconfig && make W=1 C=1 reports:
> > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/auxdisplay/line-display.o
> >
> > Add the missing invocation of the MODULE_DESCRIPTION() macro.
> >
> > Signed-off-by: Jeff Johnson <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>

Pueshed to my review and testing queue, thanks!

--
With Best Regards,
Andy Shevchenko