2022-09-19 11:27:34

by Lad, Prabhakar

[permalink] [raw]
Subject: [PATCH] soc: renesas: Kconfig: Explicitly select GPIOLIB and PINCTRL config under SOC_RENESAS

From: Lad Prabhakar <[email protected]>

GPIOLIB and PINCTRL config options are required by all ARM32/ARM64/RISC-V
Renesas SoCs, so instead of selecting them under ARCH_RENESAS for each
architecture just explicitly select them under SOC_RENESAS config option
which will be visible for all the three architectures (if ARCH_RENESAS is
enabled).

Suggested-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Lad Prabhakar <[email protected]>
---
Note, only when this patch is merged I'll post the patches to drop GPIOLIB
and PINCTRL from [0] and [1] to avoid bisect build failures.

[0] arch/arm64/Kconfig.platforms
[1] arch/arm/mach-shmobile/Kconfig
---
drivers/soc/renesas/Kconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index f95a1337450d..660498252ec5 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -2,6 +2,8 @@
menuconfig SOC_RENESAS
bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS
default y if ARCH_RENESAS
+ select GPIOLIB
+ select PINCTRL
select SOC_BUS

if SOC_RENESAS
--
2.25.1


2022-09-26 15:53:36

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] soc: renesas: Kconfig: Explicitly select GPIOLIB and PINCTRL config under SOC_RENESAS

On Mon, Sep 19, 2022 at 12:46 PM Prabhakar <[email protected]> wrote:
> From: Lad Prabhakar <[email protected]>
>
> GPIOLIB and PINCTRL config options are required by all ARM32/ARM64/RISC-V
> Renesas SoCs, so instead of selecting them under ARCH_RENESAS for each
> architecture just explicitly select them under SOC_RENESAS config option
> which will be visible for all the three architectures (if ARCH_RENESAS is
> enabled).
>
> Suggested-by: Geert Uytterhoeven <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v6.2.

> Note, only when this patch is merged I'll post the patches to drop GPIOLIB
> and PINCTRL from [0] and [1] to avoid bisect build failures.

Great!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds