This patch series has several bug fixes for the IOP driver and some
improvements to the debug level log messages.
Geert, please consider pushing these fixes for v5.8, if not the
whole series.
Finn Thain (4):
m68k/mac: Don't send IOP message until channel is idle
m68k/mac: Fix IOP status/control register writes
m68k/mac: Don't send uninitialized data in IOP message reply
m68k/mac: Improve IOP debug messages
arch/m68k/mac/iop.c | 60 ++++++++++++++++++++-------------------------
1 file changed, 26 insertions(+), 34 deletions(-)
--
2.26.2
Clear the message reply before calling iop_complete(). This code path is
not normally executed but should that happen let's arrange for consistent
behaviour from the IOP.
Cc: Joshua Thompson <[email protected]>
Tested-by: Stan Johnson <[email protected]>
Signed-off-by: Finn Thain <[email protected]>
---
arch/m68k/mac/iop.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/m68k/mac/iop.c b/arch/m68k/mac/iop.c
index 5fc3b59ba811..8d6946edf2c8 100644
--- a/arch/m68k/mac/iop.c
+++ b/arch/m68k/mac/iop.c
@@ -449,6 +449,7 @@ static void iop_handle_recv(uint iop_num, uint chan)
iop_pr_debug("unclaimed message on iop_num %d chan %d\n",
iop_num, chan);
iop_pr_debug("%*ph\n", IOP_MSG_LEN, msg->message);
+ memset(msg->reply, 0, IOP_MSG_LEN);
iop_complete_message(msg);
}
}
--
2.26.2
Hi Finn,
On Sun, May 31, 2020 at 1:16 AM Finn Thain <[email protected]> wrote:
> This patch series has several bug fixes for the IOP driver and some
> improvements to the debug level log messages.
Thanks for your series!
> Geert, please consider pushing these fixes for v5.8, if not the
> whole series.
I'm afraid it's a bit too late for that, as I expect the v5.8 merge window
to open tonight. Unless the fix is for a regression in v5.7.
BTW, how does the issue being fixed manifest itself? That's not clear to
me from the patch description.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Sun, 31 May 2020, Geert Uytterhoeven wrote:
> Hi Finn,
>
> On Sun, May 31, 2020 at 1:16 AM Finn Thain <[email protected]> wrote:
>
> > This patch series has several bug fixes for the IOP driver and some
> > improvements to the debug level log messages.
>
> Thanks for your series!
>
Thanks for your review and for your diligence in the performance of all of
your duties as maintainer.
> > Geert, please consider pushing these fixes for v5.8, if not the whole
> > series.
>
> I'm afraid it's a bit too late for that, as I expect the v5.8 merge
> window to open tonight.
Well, it's not that important.
> Unless the fix is for a regression in v5.7.
AFAICT these bugs are as old as the original driver. But I don't think
that disqualifies them from backporting, which I plan to do that once they
hit mainline.
> BTW, how does the issue being fixed manifest itself? That's not clear to
> me from the patch description.
>
The bugs in the iop driver were found by inspection, in the course of
debugging adb-iop driver failures that Stan encountered. It's possible
that the adb-iop driver is not badly affected by these bugs (I don't
know). It's possible that the iop driver bugs are among the reasons why
the swim_iop driver was never stabilized. That driver was removed in
b21a323710e7 ("[PATCH] remove the broken BLK_DEV_SWIM_IOP driver").
On Sun, May 31, 2020 at 10:41 AM Geert Uytterhoeven
<[email protected]> wrote:
> On Sun, May 31, 2020 at 1:16 AM Finn Thain <[email protected]> wrote:
> > This patch series has several bug fixes for the IOP driver and some
> > improvements to the debug level log messages.
>
> Thanks for your series!
>
> > Geert, please consider pushing these fixes for v5.8, if not the
> > whole series.
>
> I'm afraid it's a bit too late for that, as I expect the v5.8 merge window
> to open tonight. Unless the fix is for a regression in v5.7.
Queued in the m68k for-v5.9 branch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds