2021-09-22 20:17:37

by Kieran Bingham

Subject: [PATCH v2] arm64: dts: renesas: r8a779a0: falcon-cpu: Add SW47-SW49 support

Add support for SW47, SW48 and SW49 via "gpio-keys" on the R-Car V3U
Falcon board.

Signed-off-by: Kieran Bingham <[email protected]>

---
Apologies, I sent out v1 with locally staged changes that didn't get sqaushed
in.

v2:
- add wakeup-source to key-1
- make line ordering consistent across each key

.../boot/dts/renesas/r8a779a0-falcon-cpu.dtsi | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
index a0a1a1da0d87..d595fbad4589 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon-cpu.dtsi
@@ -6,6 +6,7 @@
*/

#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
#include <dt-bindings/leds/common.h>

#include "r8a779a0.dtsi"
@@ -45,6 +46,37 @@ led-3 {
};
};

+ keys {
+ compatible = "gpio-keys";
+
+ pinctrl-0 = <&keys_pins>;
+ pinctrl-names = "default";
+
+ key-1 {
+ gpios = <&gpio6 18 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_1>;
+ label = "SW47";
+ wakeup-source;
+ debounce-interval = <20>;
+ };
+
+ key-2 {
+ gpios = <&gpio6 19 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_2>;
+ label = "SW48";
+ wakeup-source;
+ debounce-interval = <20>;
+ };
+
+ key-3 {
+ gpios = <&gpio6 20 GPIO_ACTIVE_LOW>;
+ linux,code = <KEY_3>;
+ label = "SW49";
+ wakeup-source;
+ debounce-interval = <20>;
+ };
+ };
+
memory@48000000 {
device_type = "memory";
/* first 128MB is reserved for secure area. */
@@ -160,6 +192,11 @@ i2c6_pins: i2c6 {
function = "i2c6";
};

+ keys_pins: keys {
+ pins = "GP_6_18", "GP_6_19", "GP_6_20";
+ bias-pull-up;
+ };
+
mmc_pins: mmc {
groups = "mmc_data8", "mmc_ctrl", "mmc_ds";
function = "mmc";
--
2.30.2

2021-09-23 07:17:19

by Geert Uytterhoeven

Subject: Re: [PATCH v2] arm64: dts: renesas: r8a779a0: falcon-cpu: Add SW47-SW49 support

On Wed, Sep 22, 2021 at 10:13 PM Kieran Bingham
<[email protected]> wrote:
> Add support for SW47, SW48 and SW49 via "gpio-keys" on the R-Car V3U
> Falcon board.
>
> Signed-off-by: Kieran Bingham <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v5.16.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds