2023-07-09 14:05:23

by xuanzhenggang001

Subject: [PATCH] sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned'

Fix the following warnings reported by checkpatch:

arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare
use of 'unsigned'
arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare
use of 'unsigned'

Signed-off-by: Zhenggang Xuan <[email protected]>
---
arch/sh/drivers/heartbeat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c
index 24391b444b28..07f04ed0d517 100644
--- a/arch/sh/drivers/heartbeat.c
+++ b/arch/sh/drivers/heartbeat.c
@@ -30,7 +30,7 @@
static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 };

static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
- unsigned bit, unsigned int inverted)
+ unsigned int bit, unsigned int inverted)
{
unsigned int new;

@@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct
heartbeat_data *hd,
static void heartbeat_timer(struct timer_list *t)
{
struct heartbeat_data *hd = from_timer(hd, t, timer);
- static unsigned bit = 0, up = 1;
+ static unsigned int bit = 0, up = 1;

heartbeat_toggle_bit(hd, bit, hd->flags & HEARTBEAT_INVERTED);

2023-10-18 13:53:44

by Geert Uytterhoeven

Subject: Re: [PATCH] sh: heartbeat: prefer 'unsigned int' to bare use of 'unsigned'

On Sun, Jul 9, 2023 at 2:39 PM <[email protected]> wrote:
> Fix the following warnings reported by checkpatch:
>
> arch/sh/drivers/heartbeat.c:33: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
> arch/sh/drivers/heartbeat.c:62: WARNING: Prefer 'unsigned int' to bare
> use of 'unsigned'
>
> Signed-off-by: Zhenggang Xuan <[email protected]>
> ---
> arch/sh/drivers/heartbeat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sh/drivers/heartbeat.c b/arch/sh/drivers/heartbeat.c
> index 24391b444b28..07f04ed0d517 100644
> --- a/arch/sh/drivers/heartbeat.c
> +++ b/arch/sh/drivers/heartbeat.c
> @@ -30,7 +30,7 @@
> static unsigned char default_bit_pos[] = { 0, 1, 2, 3, 4, 5, 6, 7 };
>
> static inline void heartbeat_toggle_bit(struct heartbeat_data *hd,
> - unsigned bit, unsigned int inverted)
> + unsigned int bit, unsigned int inverted)
> {
> unsigned int new;
>
> @@ -59,7 +59,7 @@ static inline void heartbeat_toggle_bit(struct
> heartbeat_data *hd,

patch: **** malformed patch at line 19: heartbeat_data *hd,

Please fix your email setup.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds