2023-08-15 22:54:05

by Geert Uytterhoeven

Subject: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK

The Realtek SoC USB2 and USB3 PHY Transceivers are only present on
Realtek Digital Home Center (DHC) RTD series SoCs. Hence add a
dependency on ARCH_REALTEK, to prevent asking the user about these
drivers when configuring a kernel without Realtek SoC support.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/phy/realtek/Kconfig | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig
index 650e20ed69af41d2..75ac7e7c31aec6f2 100644
--- a/drivers/phy/realtek/Kconfig
+++ b/drivers/phy/realtek/Kconfig
@@ -2,6 +2,9 @@
#
# Phy drivers for Realtek platforms
#
+
+if ARCH_REALTEK || COMPILE_TEST
+
config PHY_RTK_RTD_USB2PHY
tristate "Realtek RTD USB2 PHY Transceiver Driver"
depends on USB_SUPPORT
@@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
The DHC (digital home center) RTD series SoCs used the Synopsys
DWC3 USB IP. This driver will do the PHY initialization
of the parameters.
+
+endif # ARCH_REALTEK || COMPILE_TEST
--
2.34.1

2023-08-17 08:43:31

by Stanley Chang[昌育德]

Subject: RE: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK

> > > diff --git a/drivers/phy/realtek/Kconfig
> > > b/drivers/phy/realtek/Kconfig index
> > > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > > --- a/drivers/phy/realtek/Kconfig
> > > +++ b/drivers/phy/realtek/Kconfig
> > > @@ -2,6 +2,9 @@
> > > #
> > > # Phy drivers for Realtek platforms #
> > > +
> > > +if ARCH_REALTEK || COMPILE_TEST
> > > +
> > > config PHY_RTK_RTD_USB2PHY
> > > tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > > depends on USB_SUPPORT
> > > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > > The DHC (digital home center) RTD series SoCs used the
> Synopsys
> > > DWC3 USB IP. This driver will do the PHY initialization
> > > of the parameters.
> > > +
> > > +endif # ARCH_REALTEK || COMPILE_TEST
> >
> > Thanks for your patch.
> > Why not use "depends on"?
> > depends on ARCH_MEDIATEK || COMPILE_TEST
>
> I think this patch is better, this way all future rtek drivers will be fixed as well,
> no need to add for each driver
>
Ok, thanks,
Stanley

2023-08-18 13:32:53

by Vinod Koul

Subject: Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK

On 17-08-23, 02:06, Stanley Chang[昌育德] wrote:
> Hi Geert,
>
> > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > --- a/drivers/phy/realtek/Kconfig
> > +++ b/drivers/phy/realtek/Kconfig
> > @@ -2,6 +2,9 @@
> > #
> > # Phy drivers for Realtek platforms
> > #
> > +
> > +if ARCH_REALTEK || COMPILE_TEST
> > +
> > config PHY_RTK_RTD_USB2PHY
> > tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > depends on USB_SUPPORT
> > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > The DHC (digital home center) RTD series SoCs used the Synopsys
> > DWC3 USB IP. This driver will do the PHY initialization
> > of the parameters.
> > +
> > +endif # ARCH_REALTEK || COMPILE_TEST
>
> Thanks for your patch.
> Why not use "depends on"?
> depends on ARCH_MEDIATEK || COMPILE_TEST

I think this patch is better, this way all future rtek drivers will be
fixed as well, no need to add for each driver

--
~Vinod

2023-08-19 11:21:56

by Stanley Chang[昌育德]

Subject: RE: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK

Hi Geert,

> diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> --- a/drivers/phy/realtek/Kconfig
> +++ b/drivers/phy/realtek/Kconfig
> @@ -2,6 +2,9 @@
> #
> # Phy drivers for Realtek platforms
> #
> +
> +if ARCH_REALTEK || COMPILE_TEST
> +
> config PHY_RTK_RTD_USB2PHY
> tristate "Realtek RTD USB2 PHY Transceiver Driver"
> depends on USB_SUPPORT
> @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> The DHC (digital home center) RTD series SoCs used the Synopsys
> DWC3 USB IP. This driver will do the PHY initialization
> of the parameters.
> +
> +endif # ARCH_REALTEK || COMPILE_TEST

Thanks for your patch.
Why not use "depends on"?
depends on ARCH_MEDIATEK || COMPILE_TEST


Thanks,
Stanley

2023-09-28 08:00:00

by Geert Uytterhoeven

Subject: Re: [PATCH] phy: realtek: Realtek PHYs should depend on ARCH_REALTEK

Hi Vinod,

On Thu, Aug 17, 2023 at 8:46 AM Vinod Koul <[email protected]> wrote:
> On 17-08-23, 02:06, Stanley Chang[昌育德] wrote:
> > > diff --git a/drivers/phy/realtek/Kconfig b/drivers/phy/realtek/Kconfig index
> > > 650e20ed69af41d2..75ac7e7c31aec6f2 100644
> > > --- a/drivers/phy/realtek/Kconfig
> > > +++ b/drivers/phy/realtek/Kconfig
> > > @@ -2,6 +2,9 @@
> > > #
> > > # Phy drivers for Realtek platforms
> > > #
> > > +
> > > +if ARCH_REALTEK || COMPILE_TEST
> > > +
> > > config PHY_RTK_RTD_USB2PHY
> > > tristate "Realtek RTD USB2 PHY Transceiver Driver"
> > > depends on USB_SUPPORT
> > > @@ -25,3 +28,5 @@ config PHY_RTK_RTD_USB3PHY
> > > The DHC (digital home center) RTD series SoCs used the Synopsys
> > > DWC3 USB IP. This driver will do the PHY initialization
> > > of the parameters.
> > > +
> > > +endif # ARCH_REALTEK || COMPILE_TEST
> >
> > Thanks for your patch.
> > Why not use "depends on"?
> > depends on ARCH_MEDIATEK || COMPILE_TEST
>
> I think this patch is better, this way all future rtek drivers will be
> fixed as well, no need to add for each driver

Is there anything still blocking this patch?
Do you want me to resend?
Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds