Subject: [PATCH] sh: pci: Remove unused variable in SH-7786 PCI Express code

Addresses the following warning when building sdk7786_defconfig:

arch/sh/drivers/pci/pcie-sh7786.c:34:22: warning: 'dma_pfn_offset' defined but not used [-Wunused-variable]
34 | static unsigned long dma_pfn_offset;
| ^~~~~~~~~~~~~~

Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")

Signed-off-by: John Paul Adrian Glaubitz <[email protected]>
---
arch/sh/drivers/pci/pcie-sh7786.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/sh/drivers/pci/pcie-sh7786.c b/arch/sh/drivers/pci/pcie-sh7786.c
index b0c2a5238d04..39bb5038e1c6 100644
--- a/arch/sh/drivers/pci/pcie-sh7786.c
+++ b/arch/sh/drivers/pci/pcie-sh7786.c
@@ -31,7 +31,6 @@ struct sh7786_pcie_port {

static struct sh7786_pcie_port *sh7786_pcie_ports;
static unsigned int nr_ports;
-static unsigned long dma_pfn_offset;
size_t memsize;
u64 memstart;

--
2.39.2


2023-04-18 16:21:50

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] sh: pci: Remove unused variable in SH-7786 PCI Express code

Hi Adrian,

Thanks for your patch!

On Tue, Apr 18, 2023 at 5:59 PM John Paul Adrian Glaubitz
<[email protected]> wrote:
> Addresses the following warning when building sdk7786_defconfig:
>
> arch/sh/drivers/pci/pcie-sh7786.c:34:22: warning: 'dma_pfn_offset' defined but not used [-Wunused-variable]
> 34 | static unsigned long dma_pfn_offset;
> | ^~~~~~~~~~~~~~
>
> Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset")
>

Please no blank line between tags and SoB.

> Signed-off-by: John Paul Adrian Glaubitz <[email protected]>

For the actual patch contents:
Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds