2024-02-23 03:52:36

by Yang Xiwen via B4 Relay

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: simple-pm-bus: Add optional resets

From: Yang Xiwen <[email protected]>

For some on-soc buses, it is also needed to deassert the resets before
access. Document it in the binding.

Signed-off-by: Yang Xiwen <[email protected]>
---
Documentation/devicetree/bindings/bus/simple-pm-bus.yaml | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml b/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml
index 182134d7a6a3..430638104980 100644
--- a/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml
+++ b/Documentation/devicetree/bindings/bus/simple-pm-bus.yaml
@@ -14,8 +14,9 @@ description: |
driver, as it's typically initialized by the boot loader.

However, its bus controller is part of a PM domain, or under the control
- of a functional clock. Hence, the bus controller's PM domain and/or
- clock must be enabled for child devices connected to the bus (either
+ of a functional clock, and it might have a reset control signal. Hence,
+ the bus controller's PM domain and/or clock must be enabled, reset control
+ signal must be deasserted for child devices connected to the bus (either
on-SoC or externally) to function.

While "simple-pm-bus" follows the "simple-bus" set of properties, as
@@ -49,6 +50,8 @@ properties:
# Required if clocks is absent, optional otherwise
minItems: 1

+ resets: true
+
required:
- compatible
- '#address-cells'

--
2.43.0



2024-02-23 08:09:13

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: simple-pm-bus: Add optional resets

On Fri, Feb 23, 2024 at 4:49 AM Yang Xiwen via B4 Relay
<[email protected]> wrote:
> From: Yang Xiwen <[email protected]>
>
> For some on-soc buses, it is also needed to deassert the resets before
> access. Document it in the binding.
>
> Signed-off-by: Yang Xiwen <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds