2019-10-04 10:30:18

by Rasmus Villemoes

Subject: [PATCH] clk: mark clk_disable_unused() as __init

clk_disable_unused is only called once, as a late_initcall, so reclaim
a bit of memory by marking it (and the functions and data it is the
sole user of) as __init/__initdata. This moves ~1900 bytes from .text
to .init.text for a imx_v6_v7_defconfig.

Signed-off-by: Rasmus Villemoes <[email protected]>
---
drivers/clk/clk.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 1c677d7f7f53..a81985285a3d 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -1187,7 +1187,7 @@ static void clk_core_disable_unprepare(struct clk_core *core)
clk_core_unprepare_lock(core);
}

-static void clk_unprepare_unused_subtree(struct clk_core *core)
+static void __init clk_unprepare_unused_subtree(struct clk_core *core)
{
struct clk_core *child;

@@ -1217,7 +1217,7 @@ static void clk_unprepare_unused_subtree(struct clk_core *core)
clk_pm_runtime_put(core);
}

-static void clk_disable_unused_subtree(struct clk_core *core)
+static void __init clk_disable_unused_subtree(struct clk_core *core)
{
struct clk_core *child;
unsigned long flags;
@@ -1263,7 +1263,7 @@ static void clk_disable_unused_subtree(struct clk_core *core)
clk_core_disable_unprepare(core->parent);
}

-static bool clk_ignore_unused;
+static bool clk_ignore_unused __initdata;
static int __init clk_ignore_unused_setup(char *__unused)
{
clk_ignore_unused = true;
@@ -1271,7 +1271,7 @@ static int __init clk_ignore_unused_setup(char *__unused)
}
__setup("clk_ignore_unused", clk_ignore_unused_setup);

-static int clk_disable_unused(void)
+static int __init clk_disable_unused(void)
{
struct clk_core *core;

--
2.20.1

2019-10-07 12:04:12

by Geert Uytterhoeven

Subject: Re: [PATCH] clk: mark clk_disable_unused() as __init

On Fri, Oct 4, 2019 at 12:30 PM Rasmus Villemoes
<[email protected]> wrote:
> clk_disable_unused is only called once, as a late_initcall, so reclaim
> a bit of memory by marking it (and the functions and data it is the
> sole user of) as __init/__initdata. This moves ~1900 bytes from .text
> to .init.text for a imx_v6_v7_defconfig.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2019-10-29 22:50:12

by Rasmus Villemoes

Subject: Re: [PATCH] clk: mark clk_disable_unused() as __init

On 07/10/2019 14.02, Geert Uytterhoeven wrote:
> On Fri, Oct 4, 2019 at 12:30 PM Rasmus Villemoes
> <[email protected]> wrote:
>> clk_disable_unused is only called once, as a late_initcall, so reclaim
>> a bit of memory by marking it (and the functions and data it is the
>> sole user of) as __init/__initdata. This moves ~1900 bytes from .text
>> to .init.text for a imx_v6_v7_defconfig.
>>
>> Signed-off-by: Rasmus Villemoes <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>

Friendly ping. Will this be picked up?

Thanks,
Rasmus

2019-10-30 14:26:20

by Stephen Boyd

Subject: Re: [PATCH] clk: mark clk_disable_unused() as __init

Quoting Rasmus Villemoes (2019-10-29 15:20:22)
> On 07/10/2019 14.02, Geert Uytterhoeven wrote:
> > On Fri, Oct 4, 2019 at 12:30 PM Rasmus Villemoes
> > <[email protected]> wrote:
> >> clk_disable_unused is only called once, as a late_initcall, so reclaim
> >> a bit of memory by marking it (and the functions and data it is the
> >> sole user of) as __init/__initdata. This moves ~1900 bytes from .text
> >> to .init.text for a imx_v6_v7_defconfig.
> >>
> >> Signed-off-by: Rasmus Villemoes <[email protected]>
> >
> > Reviewed-by: Geert Uytterhoeven <[email protected]>
>
> Friendly ping. Will this be picked up?
>

Friendly reply. Yes.

2019-11-19 22:25:41

by Stephen Boyd

Subject: Re: [PATCH] clk: mark clk_disable_unused() as __init

Quoting Rasmus Villemoes (2019-10-04 02:48:25)
> clk_disable_unused is only called once, as a late_initcall, so reclaim
> a bit of memory by marking it (and the functions and data it is the
> sole user of) as __init/__initdata. This moves ~1900 bytes from .text
> to .init.text for a imx_v6_v7_defconfig.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>
> ---

Applied to clk-next