2019-07-31 20:03:00

by Stephen Boyd

Subject: [PATCH 7/9] clk: sprd: Don't reference clk_init_data after registration

A future patch is going to change semantics of clk_register() so that
clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
referencing this member here so that we don't run into NULL pointer
exceptions.

Cc: Chunyan Zhang <[email protected]>
Cc: Baolin Wang <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---

Please ack so I can take this through clk tree

drivers/clk/sprd/common.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
index a5bdca1de5d0..9d56eac43832 100644
--- a/drivers/clk/sprd/common.c
+++ b/drivers/clk/sprd/common.c
@@ -76,16 +76,17 @@ int sprd_clk_probe(struct device *dev, struct clk_hw_onecell_data *clkhw)
struct clk_hw *hw;

for (i = 0; i < clkhw->num; i++) {
+ const char *name;

hw = clkhw->hws[i];
-
if (!hw)
continue;

+ name = hw->init->name;
ret = devm_clk_hw_register(dev, hw);
if (ret) {
dev_err(dev, "Couldn't register clock %d - %s\n",
- i, hw->init->name);
+ i, name);
return ret;
}
}
--
Sent by a computer through tubes

2019-08-01 07:50:14

by Baolin Wang

Subject: Re: [PATCH 7/9] clk: sprd: Don't reference clk_init_data after registration

Hi,

On Thu, 1 Aug 2019 at 03:35, Stephen Boyd <[email protected]> wrote:
>
> A future patch is going to change semantics of clk_register() so that
> clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
> referencing this member here so that we don't run into NULL pointer
> exceptions.
>
> Cc: Chunyan Zhang <[email protected]>
> Cc: Baolin Wang <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
>
> Please ack so I can take this through clk tree

Thanks.
Acked-by: Baolin Wang <[email protected]>

--
Baolin Wang
Best Regards

2019-08-02 02:32:32

by Chunyan Zhang

Subject: Re: [PATCH 7/9] clk: sprd: Don't reference clk_init_data after registration

On Thu, 1 Aug 2019 at 03:35, Stephen Boyd <[email protected]> wrote:
>
> A future patch is going to change semantics of clk_register() so that
> clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
> referencing this member here so that we don't run into NULL pointer
> exceptions.
>
> Cc: Chunyan Zhang <[email protected]>
> Cc: Baolin Wang <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
>
> Please ack so I can take this through clk tree

Acked-by: Chunyan Zhang <[email protected]>

Thanks.

>
> drivers/clk/sprd/common.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c
> index a5bdca1de5d0..9d56eac43832 100644
> --- a/drivers/clk/sprd/common.c
> +++ b/drivers/clk/sprd/common.c
> @@ -76,16 +76,17 @@ int sprd_clk_probe(struct device *dev, struct clk_hw_onecell_data *clkhw)
> struct clk_hw *hw;
>
> for (i = 0; i < clkhw->num; i++) {
> + const char *name;
>
> hw = clkhw->hws[i];
> -
> if (!hw)
> continue;
>
> + name = hw->init->name;
> ret = devm_clk_hw_register(dev, hw);
> if (ret) {
> dev_err(dev, "Couldn't register clock %d - %s\n",
> - i, hw->init->name);
> + i, name);
> return ret;
> }
> }
> --
> Sent by a computer through tubes
>

2019-08-14 00:26:48

by Stephen Boyd

Subject: Re: [PATCH 7/9] clk: sprd: Don't reference clk_init_data after registration

Quoting Stephen Boyd (2019-07-31 12:35:15)
> A future patch is going to change semantics of clk_register() so that
> clk_hw::init is guaranteed to be NULL after a clk is registered. Avoid
> referencing this member here so that we don't run into NULL pointer
> exceptions.
>
> Cc: Chunyan Zhang <[email protected]>
> Cc: Baolin Wang <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---

Applied to clk-next