dpm_sysfs_remove() and device_pm_remove() are already called by
device_del() on device removal so there is no need to call
device_init_wakeup(dev, false) from the driver and it allows to remove the
.remove callback.
Signed-off-by: Alexandre Belloni <[email protected]>
---
drivers/rtc/rtc-sc27xx.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c
index b95676899750..36810dd40cd3 100644
--- a/drivers/rtc/rtc-sc27xx.c
+++ b/drivers/rtc/rtc-sc27xx.c
@@ -661,12 +661,6 @@ static int sprd_rtc_probe(struct platform_device *pdev)
return 0;
}
-static int sprd_rtc_remove(struct platform_device *pdev)
-{
- device_init_wakeup(&pdev->dev, 0);
- return 0;
-}
-
static const struct of_device_id sprd_rtc_of_match[] = {
{ .compatible = "sprd,sc2731-rtc", },
{ },
@@ -679,7 +673,6 @@ static struct platform_driver sprd_rtc_driver = {
.of_match_table = sprd_rtc_of_match,
},
.probe = sprd_rtc_probe,
- .remove = sprd_rtc_remove,
};
module_platform_driver(sprd_rtc_driver);
--
2.21.0
On Mon, 21 Oct 2019 at 23:58, Alexandre Belloni
<[email protected]> wrote:
>
> dpm_sysfs_remove() and device_pm_remove() are already called by
> device_del() on device removal so there is no need to call
> device_init_wakeup(dev, false) from the driver and it allows to remove the
> .remove callback.
Right, feel free to add my tag, thanks.
Reviewed-by: Baolin Wang <[email protected]>
>
> Signed-off-by: Alexandre Belloni <[email protected]>
> ---
> drivers/rtc/rtc-sc27xx.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/rtc/rtc-sc27xx.c b/drivers/rtc/rtc-sc27xx.c
> index b95676899750..36810dd40cd3 100644
> --- a/drivers/rtc/rtc-sc27xx.c
> +++ b/drivers/rtc/rtc-sc27xx.c
> @@ -661,12 +661,6 @@ static int sprd_rtc_probe(struct platform_device *pdev)
> return 0;
> }
>
> -static int sprd_rtc_remove(struct platform_device *pdev)
> -{
> - device_init_wakeup(&pdev->dev, 0);
> - return 0;
> -}
> -
> static const struct of_device_id sprd_rtc_of_match[] = {
> { .compatible = "sprd,sc2731-rtc", },
> { },
> @@ -679,7 +673,6 @@ static struct platform_driver sprd_rtc_driver = {
> .of_match_table = sprd_rtc_of_match,
> },
> .probe = sprd_rtc_probe,
> - .remove = sprd_rtc_remove,
> };
> module_platform_driver(sprd_rtc_driver);
>
> --
> 2.21.0
>
--
Baolin Wang
Best Regards