2014-06-16 12:18:09

by Jean Delvare

Subject: [PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2

I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are
only needed on the MMP architecture. So add a hardware dependency on
ARCH_MMP, so that other users don't get to build useless drivers.

Signed-off-by: Jean Delvare <[email protected]>
Cc: Chris Ball <[email protected]>
Cc: Ulf Hansson <[email protected]>
Cc: Eric Miao <[email protected]>
Cc: Haojian Zhuang <[email protected]>
---
Changes since v1:
* Rebased on kernel 3.16-rc1

drivers/mmc/host/Kconfig | 2 ++
1 file changed, 2 insertions(+)

--- linux-3.16-rc1.orig/drivers/mmc/host/Kconfig 2014-06-16 14:03:26.195946537 +0200
+++ linux-3.16-rc1/drivers/mmc/host/Kconfig 2014-06-16 14:04:02.128663037 +0200
@@ -217,6 +217,7 @@ config MMC_SDHCI_PXAV3
tristate "Marvell MMP2 SD Host Controller support (PXAV3)"
depends on CLKDEV_LOOKUP
depends on MMC_SDHCI_PLTFM
+ depends on ARCH_MMP || COMPILE_TEST
default CPU_MMP2
help
This selects the Marvell(R) PXAV3 SD Host Controller.
@@ -229,6 +230,7 @@ config MMC_SDHCI_PXAV2
tristate "Marvell PXA9XX SD Host Controller support (PXAV2)"
depends on CLKDEV_LOOKUP
depends on MMC_SDHCI_PLTFM
+ depends on ARCH_MMP || COMPILE_TEST
default CPU_PXA910
help
This selects the Marvell(R) PXAV2 SD Host Controller.


--
Jean Delvare
SUSE L3 Support

2014-06-17 00:21:06

by Haojian Zhuang

Subject: Re: [PATCH v2] mmc: Add hardware dependencies for sdhci-pxav3 and sdhci-pxav2

On Mon, Jun 16, 2014 at 8:18 PM, Jean Delvare <[email protected]> wrote:
> I seem to understand that the sdhci-pxav3 and sdhci-pxav2 drivers are
> only needed on the MMP architecture. So add a hardware dependency on
> ARCH_MMP, so that other users don't get to build useless drivers.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Chris Ball <[email protected]>
> Cc: Ulf Hansson <[email protected]>
> Cc: Eric Miao <[email protected]>
> Cc: Haojian Zhuang <[email protected]>
> ---
> Changes since v1:
> * Rebased on kernel 3.16-rc1
>
> drivers/mmc/host/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-3.16-rc1.orig/drivers/mmc/host/Kconfig 2014-06-16 14:03:26.195946537 +0200
> +++ linux-3.16-rc1/drivers/mmc/host/Kconfig 2014-06-16 14:04:02.128663037 +0200
> @@ -217,6 +217,7 @@ config MMC_SDHCI_PXAV3
> tristate "Marvell MMP2 SD Host Controller support (PXAV3)"
> depends on CLKDEV_LOOKUP
> depends on MMC_SDHCI_PLTFM
> + depends on ARCH_MMP || COMPILE_TEST
> default CPU_MMP2
> help
> This selects the Marvell(R) PXAV3 SD Host Controller.
> @@ -229,6 +230,7 @@ config MMC_SDHCI_PXAV2
> tristate "Marvell PXA9XX SD Host Controller support (PXAV2)"
> depends on CLKDEV_LOOKUP
> depends on MMC_SDHCI_PLTFM
> + depends on ARCH_MMP || COMPILE_TEST
> default CPU_PXA910
> help
> This selects the Marvell(R) PXAV2 SD Host Controller.
>
>

Acked-by: Haojian Zhuang <[email protected]>