2014-06-05 19:18:03

by Andrew Ruder

Subject: [PATCH] arm: pxa: correct errata number for PXA270

Comment incorrectly cites errata 39
E39. SDIO: SDIO Devices Not Working at 19.5 Mbps

Should be errata 38
E38. MEMC: Memory Controller hangs when entering Self Refresh Mode.

Signed-off-by: Andrew Ruder <[email protected]>
---
arch/arm/mach-pxa/sleep.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-pxa/sleep.S b/arch/arm/mach-pxa/sleep.S
index 1e544be..6c5b3ff 100644
--- a/arch/arm/mach-pxa/sleep.S
+++ b/arch/arm/mach-pxa/sleep.S
@@ -157,7 +157,7 @@ pxa_cpu_do_suspend:
@ Do not reorder...
@ Intel PXA270 Specification Update notes problems performing
@ external accesses after SDRAM is put in self-refresh mode
- @ (see Errata 39 ...hangs when entering self-refresh mode)
+ @ (see Errata 38 ...hangs when entering self-refresh mode)

@ force address lines low by reading at physical address 0
ldr r3, [r2]
--
1.9.0.rc3.12.gbc97e2d

2014-06-05 19:18:04

by Andrew Ruder

Subject: [PATCH] arm: pxa: call debug_ll_io_init for earlyprintk

This is already done automatically for many other ARM platforms by the
ARM core code, but since pxa is using the .map_io callback, it needs to
call it explicitely for earlyprintk support.

Signed-off-by: Andrew Ruder <[email protected]>
---
arch/arm/mach-pxa/generic.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c
index 4225417..94f49c2 100644
--- a/arch/arm/mach-pxa/generic.c
+++ b/arch/arm/mach-pxa/generic.c
@@ -93,5 +93,6 @@ static struct map_desc common_io_desc[] __initdata = {

void __init pxa_map_io(void)
{
+ debug_ll_io_init();
iotable_init(ARRAY_AND_SIZE(common_io_desc));
}
--
1.9.0.rc3.12.gbc97e2d

2014-07-04 12:28:40

by Haojian Zhuang

Subject: Re: [PATCH] arm: pxa: correct errata number for PXA270

On Fri, Jun 6, 2014 at 3:10 AM, Andrew Ruder
<[email protected]> wrote:
> Comment incorrectly cites errata 39
> E39. SDIO: SDIO Devices Not Working at 19.5 Mbps
>
> Should be errata 38
> E38. MEMC: Memory Controller hangs when entering Self Refresh Mode.
>
> Signed-off-by: Andrew Ruder <[email protected]>
> ---
> arch/arm/mach-pxa/sleep.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-pxa/sleep.S b/arch/arm/mach-pxa/sleep.S
> index 1e544be..6c5b3ff 100644
> --- a/arch/arm/mach-pxa/sleep.S
> +++ b/arch/arm/mach-pxa/sleep.S
> @@ -157,7 +157,7 @@ pxa_cpu_do_suspend:
> @ Do not reorder...
> @ Intel PXA270 Specification Update notes problems performing
> @ external accesses after SDRAM is put in self-refresh mode
> - @ (see Errata 39 ...hangs when entering self-refresh mode)
> + @ (see Errata 38 ...hangs when entering self-refresh mode)
>
> @ force address lines low by reading at physical address 0
> ldr r3, [r2]
> --
> 1.9.0.rc3.12.gbc97e2d
>

Acked-by: Haojian Zhuang <[email protected]>

2014-07-04 12:39:37

by Haojian Zhuang

Subject: Re: [PATCH] arm: pxa: call debug_ll_io_init for earlyprintk

On Fri, Jun 6, 2014 at 3:10 AM, Andrew Ruder
<[email protected]> wrote:
> This is already done automatically for many other ARM platforms by the
> ARM core code, but since pxa is using the .map_io callback, it needs to
> call it explicitely for earlyprintk support.
>
> Signed-off-by: Andrew Ruder <[email protected]>
> ---
> arch/arm/mach-pxa/generic.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-pxa/generic.c b/arch/arm/mach-pxa/generic.c
> index 4225417..94f49c2 100644
> --- a/arch/arm/mach-pxa/generic.c
> +++ b/arch/arm/mach-pxa/generic.c
> @@ -93,5 +93,6 @@ static struct map_desc common_io_desc[] __initdata = {
>
> void __init pxa_map_io(void)
> {
> + debug_ll_io_init();
> iotable_init(ARRAY_AND_SIZE(common_io_desc));
> }
> --
> 1.9.0.rc3.12.gbc97e2d
>

Acked-by: Haojian Zhuang <[email protected]>