2012-11-06 07:49:06

by Qing Xu

Subject: [PATCH 7/7] mfd: max8925: add dts

From: Qing Xu <[email protected]>

add max8925 dts support into mmp2 brownstone platform

Signed-off-by: Qing Xu <[email protected]>
---
arch/arm/boot/dts/mmp2-brownstone.dts | 166 +++++++++++++++++++++++++++++++++
arch/arm/boot/dts/mmp2.dtsi | 4 +-
2 files changed, 169 insertions(+), 1 deletions(-)

diff --git a/arch/arm/boot/dts/mmp2-brownstone.dts b/arch/arm/boot/dts/mmp2-brownstone.dts
index c9b4f27..e22f58c 100644
--- a/arch/arm/boot/dts/mmp2-brownstone.dts
+++ b/arch/arm/boot/dts/mmp2-brownstone.dts
@@ -29,6 +29,172 @@
};
twsi1: i2c@d4011000 {
status = "okay";
+ pmic: max8925@3c {
+ compatible = "marvell,max8925";
+ reg = <0x3c>;
+ interrupts = <1 0>;
+ interrupt-parent = <&intcmux4>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ regulators {
+ SDV1 {
+ regulator-min-microvolt = <637500>;
+ regulator-max-microvolt = <1425000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ SDV2 {
+ regulator-min-microvolt = <650000>;
+ regulator-max-microvolt = <2225000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ SDV3 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO1 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO2 {
+ regulator-min-microvolt = <650000>;
+ regulator-max-microvolt = <2250000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO3 {
+ regulator-min-microvolt = <650000>;
+ regulator-max-microvolt = <2250000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO4 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO5 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO6 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO7 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO8 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO9 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO10 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ };
+ LDO11 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO12 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO13 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO14 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO15 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO16 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO17 {
+ regulator-min-microvolt = <650000>;
+ regulator-max-microvolt = <2250000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO18 {
+ regulator-min-microvolt = <650000>;
+ regulator-max-microvolt = <2250000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO19 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ LDO20 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <3900000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+ };
+ backlight {
+ dual-string = <0>;
+ };
+ charger {
+ batt-detect = <0>;
+ topoff-threshold = <1>;
+ fast-charge = <7>;
+ no-temp-support = <0>;
+ no-insert-detect = <0>;
+ };
+ rtc {
+
+ };
+ onkey {
+
+ };
+ touch {
+
+ };
+ };
};
rtc: rtc@d4010000 {
status = "okay";
diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
index 80f74e2..2165a17 100644
--- a/arch/arm/boot/dts/mmp2.dtsi
+++ b/arch/arm/boot/dts/mmp2.dtsi
@@ -41,7 +41,7 @@
mrvl,intc-nr-irqs = <64>;
};

- intcmux4@d4282150 {
+ intcmux4: intcmux4@d4282150 {
compatible = "mrvl,mmp2-mux-intc";
interrupts = <4>;
interrupt-controller;
@@ -196,6 +196,8 @@
compatible = "mrvl,mmp-twsi";
reg = <0xd4011000 0x1000>;
interrupts = <7>;
+ #address-cells = <1>;
+ #size-cells = <0>;
mrvl,i2c-fast-mode;
status = "disabled";
};
--
1.7.0.4

2012-11-23 07:28:24

by Qing Xu

Subject: Re: [PATCH 7/7] mfd: max8925: add dts

On 11/06/2012 03:49 PM, Qing Xu wrote:
> From: Qing Xu <[email protected]>
>
> add max8925 dts support into mmp2 brownstone platform
>
> Signed-off-by: Qing Xu <[email protected]>
> ---
> arch/arm/boot/dts/mmp2-brownstone.dts | 166 +++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/mmp2.dtsi | 4 +-
> 2 files changed, 169 insertions(+), 1 deletions(-)

Hi Russell, Haojian,

Could you help to review my patch, thanks a lot!

-Qing

2012-11-23 08:45:11

by Haojian Zhuang

Subject: Re: [PATCH 7/7] mfd: max8925: add dts

On Tue, Nov 6, 2012 at 3:49 PM, Qing Xu <[email protected]> wrote:
> From: Qing Xu <[email protected]>
>
> add max8925 dts support into mmp2 brownstone platform
>
> Signed-off-by: Qing Xu <[email protected]>
> ---
> arch/arm/boot/dts/mmp2-brownstone.dts | 166 +++++++++++++++++++++++++++++++++
> arch/arm/boot/dts/mmp2.dtsi | 4 +-
> 2 files changed, 169 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mmp2-brownstone.dts b/arch/arm/boot/dts/mmp2-brownstone.dts
> index c9b4f27..e22f58c 100644
> --- a/arch/arm/boot/dts/mmp2-brownstone.dts
> +++ b/arch/arm/boot/dts/mmp2-brownstone.dts
> @@ -29,6 +29,172 @@
> };
> twsi1: i2c@d4011000 {
> status = "okay";
> + pmic: max8925@3c {
> + compatible = "marvell,max8925";
> + reg = <0x3c>;
> + interrupts = <1 0>;
> + interrupt-parent = <&intcmux4>;
> + interrupt-controller;
> + #interrupt-cells = <1>;
> +
> + regulators {
> + SDV1 {
> + regulator-min-microvolt = <637500>;
> + regulator-max-microvolt = <1425000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> + SDV2 {
> + regulator-min-microvolt = <650000>;
> + regulator-max-microvolt = <2225000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> + };
> + backlight {
> + dual-string = <0>;
> + };
> + charger {
> + batt-detect = <0>;
> + topoff-threshold = <1>;
> + fast-charge = <7>;
> + no-temp-support = <0>;
> + no-insert-detect = <0>;
> + };
> + rtc {
> +
> + };
> + onkey {
> +
> + };
> + touch {
> +
> + };

Please remove these empty entries. Those mfd client drivers didn't parse any
property from DTS file.

> + };
> };
> rtc: rtc@d4010000 {
> status = "okay";
> diff --git a/arch/arm/boot/dts/mmp2.dtsi b/arch/arm/boot/dts/mmp2.dtsi
> index 80f74e2..2165a17 100644
> --- a/arch/arm/boot/dts/mmp2.dtsi
> +++ b/arch/arm/boot/dts/mmp2.dtsi
> @@ -41,7 +41,7 @@
> mrvl,intc-nr-irqs = <64>;
> };
>
> - intcmux4@d4282150 {
> + intcmux4: intcmux4@d4282150 {
> compatible = "mrvl,mmp2-mux-intc";
> interrupts = <4>;
> interrupt-controller;
> @@ -196,6 +196,8 @@
> compatible = "mrvl,mmp-twsi";
> reg = <0xd4011000 0x1000>;
> interrupts = <7>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> mrvl,i2c-fast-mode;
> status = "disabled";
> };
> --
> 1.7.0.4
>