2012-10-02 02:31:59

by Haojian Zhuang

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] mfd: 88pm860x: use irqdomain

On Sat, Sep 29, 2012 at 7:28 AM, Samuel Ortiz <[email protected]> wrote:
> Hi Haojian:
>
> On Fri, Sep 21, 2012 at 06:06:51PM +0800, Haojian Zhuang wrote:
>> @@ -593,13 +610,9 @@ static int __devinit device_irq_init(struct pm860x_chip *chip,
>> : chip->companion;
>> unsigned char status_buf[INT_STATUS_NUM];
>> unsigned long flags = IRQF_TRIGGER_FALLING | IRQF_ONESHOT;
>> - int i, data, mask, ret = -EINVAL;
> That one breaks the build:
>
> drivers/mfd/88pm860x-core.c: In function ?device_irq_init?:
> drivers/mfd/88pm860x-core.c:628:7: error: ?i? undeclared (first use in this
> function)
> drivers/mfd/88pm860x-core.c:628:7: note: each undeclared identifier is
> reported only once for each function it appears in
> drivers/mfd/88pm860x-core.c:629:3: error: ?__irq? undeclared (first use in
> this function)
> make[2]: *** [drivers/mfd/88pm860x-core.o] Error 1
>
> I removed this patchset until it builds...
>
I'm sorry for inconvenience. Now fix it.

Regards
Haojian


2012-10-02 09:45:12

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH v2 1/4] mfd: 88pm860x: use irqdomain

Hi Haojian,

On Tue, Oct 02, 2012 at 10:25:06AM +0800, Haojian Zhuang wrote:
> > I removed this patchset until it builds...
> >
> I'm sorry for inconvenience. Now fix it.
All 4 patches applied now.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/