2023-08-07 01:47:18

by Yang Li

Subject: [PATCH -next] drm: bridge: dw_hdmi: clean up some inconsistent indentings

drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:332 dw_hdmi_cec_suspend() warn: inconsistent indenting

Reported-by: Abaci Robot <[email protected]>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6101
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
index be21c11de1f2..14640b219dfa 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
@@ -329,9 +329,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
struct dw_hdmi_cec *cec = dev_get_drvdata(dev);

/* store interrupt status/mask registers */
- cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
- cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
- cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
+ cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
+ cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
+ cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);

return 0;
}
--
2.20.1.7.g153144c

2023-08-07 20:22:37

by Robert Foss

Subject: Re: [PATCH -next] drm: bridge: dw_hdmi: clean up some inconsistent indentings

On Mon, Aug 7, 2023 at 2:43 AM Yang Li <[email protected]> wrote:
>
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c:332 dw_hdmi_cec_suspend() warn: inconsistent indenting
>
> Reported-by: Abaci Robot <[email protected]>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6101
> Signed-off-by: Yang Li <[email protected]>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> index be21c11de1f2..14640b219dfa 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c
> @@ -329,9 +329,9 @@ static int __maybe_unused dw_hdmi_cec_suspend(struct device *dev)
> struct dw_hdmi_cec *cec = dev_get_drvdata(dev);
>
> /* store interrupt status/mask registers */
> - cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> - cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> - cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
> + cec->regs_polarity = dw_hdmi_read(cec, HDMI_CEC_POLARITY);
> + cec->regs_mask = dw_hdmi_read(cec, HDMI_CEC_MASK);
> + cec->regs_mute_stat0 = dw_hdmi_read(cec, HDMI_IH_MUTE_CEC_STAT0);
>
> return 0;
> }

NAK

The value of maintaining the git blame history is higher than
following the correct whitespace