2022-02-07 15:33:37

by kernel test robot

Subject: drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: ec648f6b7686b716424e8e73eebb4c11ae199187 pinctrl: starfive: Add pinctrl driver for StarFive SoCs
date: 7 weeks ago
config: riscv-randconfig-c003-20220206 (https://download.01.org/0day-ci/archive/20220206/[email protected]/config)
compiler: riscv64-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>


cocci warnings: (new ones prefixed by >>)
>> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

2022-02-07 17:04:19

by kernel test robot

Subject: [PATCH] pinctrl: starfive: fix semicolon.cocci warnings

From: kernel test robot <[email protected]>

drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon


Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

Reported-by: kernel test robot <[email protected]>
Signed-off-by: kernel test robot <[email protected]>
---

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 90c9e950c0def5c354b4a6154a2ddda3e5f214ac
commit: ec648f6b7686b716424e8e73eebb4c11ae199187 pinctrl: starfive: Add pinctrl driver for StarFive SoCs
:::::: branch date: 6 hours ago
:::::: commit date: 7 weeks ago

pinctrl-starfive.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/pinctrl/pinctrl-starfive.c
+++ b/drivers/pinctrl/pinctrl-starfive.c
@@ -1026,7 +1026,7 @@ static int starfive_gpio_set_config(stru
break;
default:
return -ENOTSUPP;
- };
+ }

starfive_padctl_rmw(sfp, starfive_gpio_to_pin(sfp, gpio), mask, value);
return 0;

2022-02-07 17:56:20

by Emil Renner Berthing

Subject: Re: [PATCH] pinctrl: starfive: fix semicolon.cocci warnings

On Sun, 6 Feb 2022 at 01:38, kernel test robot <[email protected]> wrote:
>
> From: kernel test robot <[email protected]>
>
> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: kernel test robot <[email protected]>

Thanks. There is already a previous patch for this although it was
sent before this code was in Linus' tree:
https://lore.kernel.org/all/[email protected]/

/Emil

2022-02-11 16:40:37

by Linus Walleij

Subject: Re: [PATCH] pinctrl: starfive: fix semicolon.cocci warnings

On Sun, Feb 6, 2022 at 1:37 AM kernel test robot <[email protected]> wrote:

> From: kernel test robot <[email protected]>
>
> drivers/pinctrl/pinctrl-starfive.c:1029:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: kernel test robot <[email protected]>

Applied this patch and added the alibaba reporters as
Reported-by.

Yours,
Linus Walleij