2015-04-01 07:21:27

by Alexander Kuleshov

[permalink] [raw]
Subject: Re: [PATCH] mm/memblock: add debug output for the memblock_add

2015-04-01 5:38 GMT+06:00 Andrew Morton <[email protected]>:
> On Sat, 28 Mar 2015 23:08:03 +0600 Alexander Kuleshov <[email protected]> wrote:
>
> I guess this should be "memblock_add:". That's what
> memblock_reserve_region() does?
>
> --- a/mm/memblock.c~mm-memblock-add-debug-output-for-the-memblock_add-fix
> +++ a/mm/memblock.c
> @@ -587,7 +587,7 @@ static int __init_memblock memblock_add_
> {
> struct memblock_type *_rgn = &memblock.memory;
>
> - memblock_dbg("memblock_memory: [%#016llx-%#016llx] flags %#02lx %pF\n",
> + memblock_dbg("memblock_add: [%#016llx-%#016llx] flags %#02lx %pF\n",
> (unsigned long long)base,
> (unsigned long long)base + size - 1,
> flags, (void *)_RET_IP_);
> _
>

Yes, it is much cleaner. Thank you Andrew.