2022-10-11 03:19:54

by ye xingchen

Subject: [PATCH linux-next] timers: replace in_irq() with in_hardirq()

From: ye xingchen <[email protected]>

Replace the obsolete and ambiguos macro in_irq() with new
macro in_hardirq().

Signed-off-by: ye xingchen <[email protected]>
---
kernel/time/timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index 717fcb9fb14a..f65e3e00ef61 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1838,7 +1838,7 @@ void update_process_times(int user_tick)
run_local_timers();
rcu_sched_clock_irq(user_tick);
#ifdef CONFIG_IRQ_WORK
- if (in_irq())
+ if (in_hardirq())
irq_work_tick();
#endif
scheduler_tick();
--
2.25.1

2022-10-11 18:59:20

by John Stultz

Subject: Re: [PATCH linux-next] timers: replace in_irq() with in_hardirq()

On Mon, Oct 10, 2022 at 8:06 PM <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Replace the obsolete and ambiguos macro in_irq() with new
> macro in_hardirq().

Would it make sense to replace both instances of in_irq() in that file at once?

thanks
-john