2013-07-02 01:49:56

by Grant Grundler

[permalink] [raw]
Subject: Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote:
> This commit adds cache flush for removed small page and large page
> entries in exynos_iommu_unmap(). Missing cache flush of removed
> page table entries can cause missing page fault interrupt when a
> master IP accesses an unmapped area.

KyongHo,
It appears this patch was never applied and got caught up in the
device tree binding discussion. AFAICT, this patch is still necessary.
Can you resubmit this patch separately. Or ok if I do?

Original patch is here:
https://patchwork.kernel.org/patch/1910261/

thanks,
grant


2013-07-02 02:21:12

by Grant Grundler

[permalink] [raw]
Subject: Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

-linux-arm (wrong email address - sorry)

On Mon, Jul 1, 2013 at 6:49 PM, Grant Grundler <[email protected]> wrote:
> On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote:
>> This commit adds cache flush for removed small page and large page
>> entries in exynos_iommu_unmap(). Missing cache flush of removed
>> page table entries can cause missing page fault interrupt when a
>> master IP accesses an unmapped area.
>
> KyongHo,
> It appears this patch was never applied and got caught up in the
> device tree binding discussion. AFAICT, this patch is still necessary.
> Can you resubmit this patch separately. Or ok if I do?
>
> Original patch is here:
> https://patchwork.kernel.org/patch/1910261/
>
> thanks,
> grant

2013-07-03 20:43:56

by Grant Grundler

[permalink] [raw]
Subject: Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

Ping?

On Mon, Jul 1, 2013 at 6:49 PM, Grant Grundler <[email protected]> wrote:
> On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote:
>> This commit adds cache flush for removed small page and large page
>> entries in exynos_iommu_unmap(). Missing cache flush of removed
>> page table entries can cause missing page fault interrupt when a
>> master IP accesses an unmapped area.
>
> KyongHo,
> It appears this patch was never applied and got caught up in the
> device tree binding discussion. AFAICT, this patch is still necessary.
> Can you resubmit this patch separately. Or ok if I do?
>
> Original patch is here:
> https://patchwork.kernel.org/patch/1910261/
>
> thanks,
> grant

2013-07-04 11:20:52

by Cho KyongHo

[permalink] [raw]
Subject: RE: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

> From: [email protected] [mailto:[email protected]] On Behalf Of Grant Grundler
> Sent: Thursday, July 04, 2013 5:44 AM
>
> Ping?
Hi.

Sorry for late update the patch set.
I am still working on the patch set when I am free.
Implementation of the updated patch set has been finished but not tested yet.

I will post the patches after simple test :)

Thank you.
>
> On Mon, Jul 1, 2013 at 6:49 PM, Grant Grundler <[email protected]> wrote:
> > On Tuesday, December 25, 2012 6:00:01 PM UTC-8, Cho KyongHo wrote:
> >> This commit adds cache flush for removed small page and large page
> >> entries in exynos_iommu_unmap(). Missing cache flush of removed page
> >> table entries can cause missing page fault interrupt when a master IP
> >> accesses an unmapped area.
> >
> > KyongHo,
> > It appears this patch was never applied and got caught up in the
> > device tree binding discussion. AFAICT, this patch is still necessary.
> > Can you resubmit this patch separately. Or ok if I do?
> >
> > Original patch is here:
> > https://patchwork.kernel.org/patch/1910261/
> >
> > thanks,
> > grant

2013-07-08 18:21:54

by Grant Grundler

[permalink] [raw]
Subject: Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

On Thu, Jul 4, 2013 at 4:20 AM, Cho KyongHo <[email protected]> wrote:
...
> I am still working on the patch set when I am free.
> Implementation of the updated patch set has been finished but not tested yet.
>
> I will post the patches after simple test :)

Ok - thanks Cho!

If you'd like me to test, please post a "RFC" (request for comment)
version that hasn't yet been tested. You don't have to do everything
yourself. :)

cheers,
grant

2013-07-08 18:29:25

by Grant Grundler

[permalink] [raw]
Subject: Re: [PATCH v6 01/12] iommu/exynos: add missing cache flush for removed pagetable entries

On Mon, Jul 8, 2013 at 11:21 AM, Grant Grundler <[email protected]> wrote:
> On Thu, Jul 4, 2013 at 4:20 AM, Cho KyongHo <[email protected]> wrote:
> ...
>> I am still working on the patch set when I am free.
>> Implementation of the updated patch set has been finished but not tested yet.
>>
>> I will post the patches after simple test :)
>
> Ok - thanks Cho!
>
> If you'd like me to test, please post a "RFC" (request for comment)
> version that hasn't yet been tested. You don't have to do everything
> yourself. :)

Nevermind...I'm catching on email in reverse and see that you've
already posted the patches!

I'll try to test those today. :)

thanks!
grant