2022-04-05 01:57:49

by Arnaud Pouliquen

Subject: [PATCH] arm: configs: Configs that had RPMSG_CHAR now get RPMSG_CTRL

In the patch 617d32938d1b: "rpmsg: Move the rpmsg control device
from rpmsg_char to rpmsg_ctrl", we split the rpmsg_char driver in two.
By default give everyone who had the old driver enabled the rpmsg_ctrl
driver too.

Fixes: 617d32938d1b ("rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl", 2022-01-24)
Signed-off-by: Arnaud Pouliquen <[email protected]>
---

This patch is extracted from the series [1] that has been partially
integrated in the Linux Kernel 5.18-rc1.

[1]https://lore.kernel.org/lkml/[email protected]/T/
---
arch/arm/configs/qcom_defconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
index 9981566f2096..2e7e9a4f31f6 100644
--- a/arch/arm/configs/qcom_defconfig
+++ b/arch/arm/configs/qcom_defconfig
@@ -241,6 +241,7 @@ CONFIG_QCOM_Q6V5_PAS=y
CONFIG_QCOM_Q6V5_PIL=y
CONFIG_QCOM_WCNSS_PIL=y
CONFIG_RPMSG_CHAR=y
+CONFIG_RPMSG_CTRL=y
CONFIG_RPMSG_QCOM_GLINK_SMEM=y
CONFIG_RPMSG_QCOM_SMD=y
CONFIG_QCOM_COMMAND_DB=y
--
2.25.1

2022-04-05 02:08:09

by Mathieu Poirier

Subject: Re: [PATCH] arm: configs: Configs that had RPMSG_CHAR now get RPMSG_CTRL

Good day,

On Mon, 4 Apr 2022 at 03:01, Arnaud Pouliquen
<[email protected]> wrote:
>
> In the patch 617d32938d1b: "rpmsg: Move the rpmsg control device
> from rpmsg_char to rpmsg_ctrl", we split the rpmsg_char driver in two.
> By default give everyone who had the old driver enabled the rpmsg_ctrl
> driver too.
>
> Fixes: 617d32938d1b ("rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl", 2022-01-24)

A date should not appear in a Fixes tag - please remove. I would also
remove the entire tag since there was nothing wrong with commit
617d32938d1b. Re-organising and splitting things up is part of normal
kernel development, and that process often implies modifications to
the kernel config files.

Same comment for the other 2 patches.

Thanks,
Mathieu


> Signed-off-by: Arnaud Pouliquen <[email protected]>
> ---
>
> This patch is extracted from the series [1] that has been partially
> integrated in the Linux Kernel 5.18-rc1.
>
> [1]https://lore.kernel.org/lkml/[email protected]/T/
> ---
> arch/arm/configs/qcom_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/qcom_defconfig b/arch/arm/configs/qcom_defconfig
> index 9981566f2096..2e7e9a4f31f6 100644
> --- a/arch/arm/configs/qcom_defconfig
> +++ b/arch/arm/configs/qcom_defconfig
> @@ -241,6 +241,7 @@ CONFIG_QCOM_Q6V5_PAS=y
> CONFIG_QCOM_Q6V5_PIL=y
> CONFIG_QCOM_WCNSS_PIL=y
> CONFIG_RPMSG_CHAR=y
> +CONFIG_RPMSG_CTRL=y
> CONFIG_RPMSG_QCOM_GLINK_SMEM=y
> CONFIG_RPMSG_QCOM_SMD=y
> CONFIG_QCOM_COMMAND_DB=y
> --
> 2.25.1
>