typec_partner_set_pd_revision returns void now.
Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision from status")
Signed-off-by: Benson Leung <[email protected]>
---
drivers/platform/chrome/cros_ec_typec.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index a7778258d0a0..7b93dfd02999 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -842,11 +842,7 @@ static int cros_typec_handle_sop_disc(struct cros_typec_data *typec, int port_nu
goto disc_exit;
}
- ret = typec_partner_set_pd_revision(port->partner, pd_revision);
- if (ret < 0) {
- dev_err(typec->dev, "Failed to update partner PD revision, port: %d\n", port_num);
- goto disc_exit;
- }
+ typec_partner_set_pd_revision(port->partner, pd_revision);
memset(sop_disc, 0, EC_PROTO2_MAX_RESPONSE_SIZE);
ret = cros_typec_ec_command(typec, 0, EC_CMD_TYPEC_DISCOVERY, &req, sizeof(req),
--
2.30.0.365.g02bc693789-goog
On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote:
> typec_partner_set_pd_revision returns void now.
>
> Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision from status")
> Signed-off-by: Benson Leung <[email protected]>
> ---
> drivers/platform/chrome/cros_ec_typec.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
What changed from "v1"?
Hi Greg,
On Tue, Feb 2, 2021 at 9:02 AM Greg KH <[email protected]> wrote:
>
> On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote:
> > typec_partner_set_pd_revision returns void now.
> >
> > Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision from status")
> > Signed-off-by: Benson Leung <[email protected]>
> > ---
> > drivers/platform/chrome/cros_ec_typec.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
>
> What changed from "v1"?
>
Just the "Fixes" line in the commit message.
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]
On Tue, Feb 02, 2021 at 09:52:13AM -0800, Benson Leung wrote:
> Hi Greg,
>
> On Tue, Feb 2, 2021 at 9:02 AM Greg KH <[email protected]> wrote:
> >
> > On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote:
> > > typec_partner_set_pd_revision returns void now.
> > >
> > > Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision from status")
> > > Signed-off-by: Benson Leung <[email protected]>
> > > ---
> > > drivers/platform/chrome/cros_ec_typec.c | 6 +-----
> > > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > What changed from "v1"?
> >
>
> Just the "Fixes" line in the commit message.
That should always go below the --- line, remember, some of us deal with
hundreds of patches a day :)
I'll go take this...
thanks,
greg k-h
On Tue, Feb 02, 2021 at 07:30:06PM +0100, Greg KH wrote:
> On Tue, Feb 02, 2021 at 09:52:13AM -0800, Benson Leung wrote:
> > Hi Greg,
> >
> > On Tue, Feb 2, 2021 at 9:02 AM Greg KH <[email protected]> wrote:
> > >
> > > On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote:
> > > > typec_partner_set_pd_revision returns void now.
> > > >
> > > > Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision from status")
> > > > Signed-off-by: Benson Leung <[email protected]>
> > > > ---
> > > > drivers/platform/chrome/cros_ec_typec.c | 6 +-----
> > > > 1 file changed, 1 insertion(+), 5 deletions(-)
> > >
> > > What changed from "v1"?
> > >
> >
> > Just the "Fixes" line in the commit message.
>
> That should always go below the --- line, remember, some of us deal with
> hundreds of patches a day :)
>
> I'll go take this...
Thanks so much, Greg!
Benson
>
> thanks,
>
> greg k-h
--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]