2016-03-29 20:10:56

by Gabriele Mazzotta

Subject: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume

input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called
at each frame. Do it when releasing the touches, or else we won't get
a proper slot number after mt_reset_resume().

Signed-off-by: Gabriele Mazzotta <[email protected]>
---
drivers/hid/hid-multitouch.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 25d3c43..c741f5e 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid)
MT_TOOL_FINGER,
false);
}
+ input_mt_sync_frame(input_dev);
input_sync(input_dev);
}
}
--
2.8.0.rc3

2016-03-29 20:36:14

by Benson Leung

Subject: Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume

Hi Gabriele,

Thanks for the fix!

On Tue, Mar 29, 2016 at 1:10 PM, Gabriele Mazzotta
<[email protected]> wrote:
> input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called
> at each frame. Do it when releasing the touches, or else we won't get
> a proper slot number after mt_reset_resume().
>
> Signed-off-by: Gabriele Mazzotta <[email protected]>

Reviewed-by: Benson Leung <[email protected]>

> ---
> drivers/hid/hid-multitouch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 25d3c43..c741f5e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid)
> MT_TOOL_FINGER,
> false);
> }
> + input_mt_sync_frame(input_dev);
> input_sync(input_dev);
> }
> }
> --
> 2.8.0.rc3
>



--
Benson Leung
Senior Software Engineer, Chrom* OS
[email protected]

2016-03-30 07:46:35

by Benjamin Tissoires

Subject: Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume

On Mar 29 2016 or thereabouts, Gabriele Mazzotta wrote:
> input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called
> at each frame. Do it when releasing the touches, or else we won't get
> a proper slot number after mt_reset_resume().
>
> Signed-off-by: Gabriele Mazzotta <[email protected]>

Thanks for the fix (I should have spot that earlier :( )

Reviewed-by: Benjamin TIssoires <[email protected]>

Cheers,
Benjamin

> ---
> drivers/hid/hid-multitouch.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 25d3c43..c741f5e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1169,6 +1169,7 @@ static void mt_release_contacts(struct hid_device *hid)
> MT_TOOL_FINGER,
> false);
> }
> + input_mt_sync_frame(input_dev);
> input_sync(input_dev);
> }
> }
> --
> 2.8.0.rc3
>

2016-04-01 09:35:42

by Jiri Kosina

Subject: Re: [PATCH] HID: multitouch: Synchronize MT frame on reset_resume

On Tue, 29 Mar 2016, Gabriele Mazzotta wrote:

> input_mt_get_slot_by_key() requires input_mt_sync_frame() to be called
> at each frame. Do it when releasing the touches, or else we won't get
> a proper slot number after mt_reset_resume().
>
> Signed-off-by: Gabriele Mazzotta <[email protected]>

Queued for 4.6. Thanks,

--
Jiri Kosina
SUSE Labs