2019-06-21 13:53:52

by Yue Haibing

Subject: [PATCH -next] platform/chrome: wilco_ec: Use kmemdup in enqueue_events()

Use kmemdup rather than duplicating its implementation

Signed-off-by: YueHaibing <[email protected]>
---
drivers/platform/chrome/wilco_ec/event.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
index c975b76e6255..70156e75047e 100644
--- a/drivers/platform/chrome/wilco_ec/event.c
+++ b/drivers/platform/chrome/wilco_ec/event.c
@@ -248,10 +248,9 @@ static int enqueue_events(struct acpi_device *adev, const u8 *buf, u32 length)
offset += event_size;

/* Copy event into the queue */
- queue_event = kzalloc(event_size, GFP_KERNEL);
+ queue_event = kmemdup(event, event_size, GFP_KERNEL);
if (!queue_event)
return -ENOMEM;
- memcpy(queue_event, event, event_size);
event_queue_push(dev_data->events, queue_event);
}

2019-06-21 14:53:23

by Nick Crews

Subject: Re: [PATCH -next] platform/chrome: wilco_ec: Use kmemdup in enqueue_events()

Thanks Yue, looks good to me.

Nick

On Fri, Jun 21, 2019 at 7:59 AM YueHaibing <[email protected]> wrote:
>
> Use kmemdup rather than duplicating its implementation
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/platform/chrome/wilco_ec/event.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
> index c975b76e6255..70156e75047e 100644
> --- a/drivers/platform/chrome/wilco_ec/event.c
> +++ b/drivers/platform/chrome/wilco_ec/event.c
> @@ -248,10 +248,9 @@ static int enqueue_events(struct acpi_device *adev, const u8 *buf, u32 length)
> offset += event_size;
>
> /* Copy event into the queue */
> - queue_event = kzalloc(event_size, GFP_KERNEL);
> + queue_event = kmemdup(event, event_size, GFP_KERNEL);
> if (!queue_event)
> return -ENOMEM;
> - memcpy(queue_event, event, event_size);
> event_queue_push(dev_data->events, queue_event);
> }
>
>
>

2019-09-26 22:49:09

by Benson Leung

Subject: Re: [PATCH -next] platform/chrome: wilco_ec: Use kmemdup in enqueue_events()

Hey Nick,
On Fri, Jun 21, 2019 at 7:51 AM Nick Crews <[email protected]> wrote:
>
> Thanks Yue, looks good to me.
>
> Nick
>
> On Fri, Jun 21, 2019 at 7:59 AM YueHaibing <[email protected]> wrote:
> >
> > Use kmemdup rather than duplicating its implementation
> >
> > Signed-off-by: YueHaibing <[email protected]>
> > ---
> > drivers/platform/chrome/wilco_ec/event.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
> > index c975b76e6255..70156e75047e 100644
> > --- a/drivers/platform/chrome/wilco_ec/event.c
> > +++ b/drivers/platform/chrome/wilco_ec/event.c
> > @@ -248,10 +248,9 @@ static int enqueue_events(struct acpi_device *adev, const u8 *buf, u32 length)
> > offset += event_size;
> >
> > /* Copy event into the queue */
> > - queue_event = kzalloc(event_size, GFP_KERNEL);
> > + queue_event = kmemdup(event, event_size, GFP_KERNEL);
> > if (!queue_event)
> > return -ENOMEM;
> > - memcpy(queue_event, event, event_size);
> > event_queue_push(dev_data->events, queue_event);
> > }
> >
> >
> >

Looks like this was already incorporated into your commit,
platform/chrome: wilco_ec: Use kmemdup in enqueue_events().

Thanks!
Benson

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]

2019-09-27 17:09:09

by Nick Crews

Subject: Re: [PATCH -next] platform/chrome: wilco_ec: Use kmemdup in enqueue_events()

On Thu, Sep 26, 2019 at 4:43 PM Benson Leung <[email protected]> wrote:
>
> Hey Nick,
> On Fri, Jun 21, 2019 at 7:51 AM Nick Crews <[email protected]> wrote:
> >
> > Thanks Yue, looks good to me.
> >
> > Nick
> >
> > On Fri, Jun 21, 2019 at 7:59 AM YueHaibing <[email protected]> wrote:
> > >
> > > Use kmemdup rather than duplicating its implementation
> > >
> > > Signed-off-by: YueHaibing <[email protected]>
> > > ---
> > > drivers/platform/chrome/wilco_ec/event.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/platform/chrome/wilco_ec/event.c b/drivers/platform/chrome/wilco_ec/event.c
> > > index c975b76e6255..70156e75047e 100644
> > > --- a/drivers/platform/chrome/wilco_ec/event.c
> > > +++ b/drivers/platform/chrome/wilco_ec/event.c
> > > @@ -248,10 +248,9 @@ static int enqueue_events(struct acpi_device *adev, const u8 *buf, u32 length)
> > > offset += event_size;
> > >
> > > /* Copy event into the queue */
> > > - queue_event = kzalloc(event_size, GFP_KERNEL);
> > > + queue_event = kmemdup(event, event_size, GFP_KERNEL);
> > > if (!queue_event)
> > > return -ENOMEM;
> > > - memcpy(queue_event, event, event_size);
> > > event_queue_push(dev_data->events, queue_event);
> > > }
> > >
> > >
> > >
>
> Looks like this was already incorporated into your commit,
> platform/chrome: wilco_ec: Use kmemdup in enqueue_events().

Thanks for the note Benson, but I think that must have
been a copy pasta error, it was actually included in
"platform/chrome: wilco_ec: Add circular buffer as event queue"
just so there isn't any confusion later :)

Nick

>
> Thanks!
> Benson
>
> --
> Benson Leung
> Staff Software Engineer
> Chrome OS Kernel
> Google Inc.
> [email protected]
> Chromium OS Project
> [email protected]