From: Matthias Brugger <[email protected]>
The dsi children don't have any reg property, so we don't need address and
size cells. This makes dtbs_check happy.
CC: Hsin-Yi Wang <[email protected]>
CC: Enric Balletbo i Serra <[email protected]>
CC: Nicolas Boichat <[email protected]>
Signed-off-by: Matthias Brugger <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index ff56bcfa3370..f4dca6a33168 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -251,8 +251,7 @@ &cpu7 {
&dsi0 {
status = "okay";
- #address-cells = <1>;
- #size-cells = <0>;
+
panel: panel@0 {
/* compatible will be set in board dts */
reg = <0>;
--
2.30.2
On Wed, Apr 14, 2021 at 10:46 PM <[email protected]> wrote:
>
> From: Matthias Brugger <[email protected]>
>
> The dsi children don't have any reg property,
Confused, see below.
> so we don't need address and
> size cells. This makes dtbs_check happy.
>
> CC: Hsin-Yi Wang <[email protected]>
> CC: Enric Balletbo i Serra <[email protected]>
> CC: Nicolas Boichat <[email protected]>
> Signed-off-by: Matthias Brugger <[email protected]>
>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index ff56bcfa3370..f4dca6a33168 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -251,8 +251,7 @@ &cpu7 {
>
> &dsi0 {
> status = "okay";
> - #address-cells = <1>;
> - #size-cells = <0>;
> +
> panel: panel@0 {
> /* compatible will be set in board dts */
> reg = <0>;
^^ isn't that... a reg property?
> --
> 2.30.2
>
Hi Nicolas,
On 15/04/2021 02:29, Nicolas Boichat wrote:
> On Wed, Apr 14, 2021 at 10:46 PM <[email protected]> wrote:
>>
>> From: Matthias Brugger <[email protected]>
>>
>> The dsi children don't have any reg property,
>
> Confused, see below.
>
>> so we don't need address and
>> size cells. This makes dtbs_check happy.
>>
>> CC: Hsin-Yi Wang <[email protected]>
>> CC: Enric Balletbo i Serra <[email protected]>
>> CC: Nicolas Boichat <[email protected]>
>> Signed-off-by: Matthias Brugger <[email protected]>
>>
>> ---
>>
>> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> index ff56bcfa3370..f4dca6a33168 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>> @@ -251,8 +251,7 @@ &cpu7 {
>>
>> &dsi0 {
>> status = "okay";
>> - #address-cells = <1>;
>> - #size-cells = <0>;
>> +
>> panel: panel@0 {
>> /* compatible will be set in board dts */
>> reg = <0>;
>
> ^^ isn't that... a reg property?
>
Yes, that's my fault. I'm not quite sure why we would need this reg property. In
any case also we have it present "dtbs_check W=1" throws the following warning:
mediatek/mt8183.dtsi:1234.22-1246.5: Warning (avoid_unnecessary_addr_size):
/soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or
child "reg" property
Can you have a look at that?
Regards,
Matthias
>> --
>> 2.30.2
>>
Hi Matthias,
On 15/4/21 9:47, Matthias Brugger wrote:
> Hi Nicolas,
>
> On 15/04/2021 02:29, Nicolas Boichat wrote:
>> On Wed, Apr 14, 2021 at 10:46 PM <[email protected]> wrote:
>>>
>>> From: Matthias Brugger <[email protected]>
>>>
>>> The dsi children don't have any reg property,
>>
>> Confused, see below.
>>
>>> so we don't need address and
>>> size cells. This makes dtbs_check happy.
>>>
>>> CC: Hsin-Yi Wang <[email protected]>
>>> CC: Enric Balletbo i Serra <[email protected]>
>>> CC: Nicolas Boichat <[email protected]>
>>> Signed-off-by: Matthias Brugger <[email protected]>
>>>
>>> ---
>>>
>>> arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> index ff56bcfa3370..f4dca6a33168 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
>>> @@ -251,8 +251,7 @@ &cpu7 {
>>>
>>> &dsi0 {
>>> status = "okay";
>>> - #address-cells = <1>;
>>> - #size-cells = <0>;
>>> +
>>> panel: panel@0 {
>>> /* compatible will be set in board dts */
>>> reg = <0>;
>>
>> ^^ isn't that... a reg property?
>>
>
> Yes, that's my fault. I'm not quite sure why we would need this reg property. In
> any case also we have it present "dtbs_check W=1" throws the following warning:
> mediatek/mt8183.dtsi:1234.22-1246.5: Warning (avoid_unnecessary_addr_size):
> /soc/dsi@14014000: unnecessary #address-cells/#size-cells without "ranges" or
> child "reg" property
>
>
> Can you have a look at that?
>
I think it is needed reg. See at
Documentation/devicetree/bindings/display/dsi-controller.yaml
Regards,
Enric
> Regards,
> Matthias
>
>>> --
>>> 2.30.2
>>>