trace_printk should not be used in production code, replace it
call with pr_info.
Signed-off-by: Nicolas Boichat <[email protected]>
---
Sent this before as part of a series (whose 4th patch was a
change that allows to detect such trace_printk), but maybe it's
easier to get individual maintainer attention by splitting it.
drivers/staging/media/atomisp/pci/hmm/hmm.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/hmm/hmm.c b/drivers/staging/media/atomisp/pci/hmm/hmm.c
index 42fef17798622f1..2bd39b4939f16d2 100644
--- a/drivers/staging/media/atomisp/pci/hmm/hmm.c
+++ b/drivers/staging/media/atomisp/pci/hmm/hmm.c
@@ -735,11 +735,11 @@ ia_css_ptr hmm_host_vaddr_to_hrt_vaddr(const void *ptr)
void hmm_show_mem_stat(const char *func, const int line)
{
- trace_printk("tol_cnt=%d usr_size=%d res_size=%d res_cnt=%d sys_size=%d dyc_thr=%d dyc_size=%d.\n",
- hmm_mem_stat.tol_cnt,
- hmm_mem_stat.usr_size, hmm_mem_stat.res_size,
- hmm_mem_stat.res_cnt, hmm_mem_stat.sys_size,
- hmm_mem_stat.dyc_thr, hmm_mem_stat.dyc_size);
+ pr_info("tol_cnt=%d usr_size=%d res_size=%d res_cnt=%d sys_size=%d dyc_thr=%d dyc_size=%d.\n",
+ hmm_mem_stat.tol_cnt,
+ hmm_mem_stat.usr_size, hmm_mem_stat.res_size,
+ hmm_mem_stat.res_cnt, hmm_mem_stat.sys_size,
+ hmm_mem_stat.dyc_thr, hmm_mem_stat.dyc_size);
}
void hmm_init_mem_stat(int res_pgnr, int dyc_en, int dyc_pgnr)
--
2.27.0.383.g050319c2ae-goog
On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote:
> trace_printk should not be used in production code, replace it
> call with pr_info.
>
> Signed-off-by: Nicolas Boichat <[email protected]>
> ---
> Sent this before as part of a series (whose 4th patch was a
> change that allows to detect such trace_printk), but maybe it's
> easier to get individual maintainer attention by splitting it.
Mauro should take this soon:
Acked-by: Greg Kroah-Hartman <[email protected]>
On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote:
> > trace_printk should not be used in production code, replace it
> > call with pr_info.
> >
> > Signed-off-by: Nicolas Boichat <[email protected]>
> > ---
> > Sent this before as part of a series (whose 4th patch was a
> > change that allows to detect such trace_printk), but maybe it's
> > easier to get individual maintainer attention by splitting it.
>
> Mauro should take this soon:
>
> Acked-by: Greg Kroah-Hartman <[email protected]>
Mauro: did you get a chance to look at this? (and the other similar
patch "media: camss: vfe: Use trace_printk for debugging only")
Thanks!
On Fri, Jul 24, 2020 at 8:41 PM Nicolas Boichat <[email protected]> wrote:
>
> On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote:
> > > trace_printk should not be used in production code, replace it
> > > call with pr_info.
> > >
> > > Signed-off-by: Nicolas Boichat <[email protected]>
> > > ---
> > > Sent this before as part of a series (whose 4th patch was a
> > > change that allows to detect such trace_printk), but maybe it's
> > > easier to get individual maintainer attention by splitting it.
> >
> > Mauro should take this soon:
> >
> > Acked-by: Greg Kroah-Hartman <[email protected]>
>
> Mauro: did you get a chance to look at this? (and the other similar
> patch "media: camss: vfe: Use trace_printk for debugging only")
Mauro: Another gentle ping. Thanks.
> Thanks!
On Fri, Aug 07, 2020 at 09:50:23AM +0800, Nicolas Boichat wrote:
> On Fri, Jul 24, 2020 at 8:41 PM Nicolas Boichat <[email protected]> wrote:
> >
> > On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman
> > <[email protected]> wrote:
> > >
> > > On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote:
> > > > trace_printk should not be used in production code, replace it
> > > > call with pr_info.
> > > >
> > > > Signed-off-by: Nicolas Boichat <[email protected]>
> > > > ---
> > > > Sent this before as part of a series (whose 4th patch was a
> > > > change that allows to detect such trace_printk), but maybe it's
> > > > easier to get individual maintainer attention by splitting it.
> > >
> > > Mauro should take this soon:
> > >
> > > Acked-by: Greg Kroah-Hartman <[email protected]>
> >
> > Mauro: did you get a chance to look at this? (and the other similar
> > patch "media: camss: vfe: Use trace_printk for debugging only")
>
> Mauro: Another gentle ping. Thanks.
It's the middle of the merge window, maintainers can't do anything until
after 5.9-rc1 is out, sorry.
greg k-h
On Fri, Aug 7, 2020 at 2:28 PM Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Fri, Aug 07, 2020 at 09:50:23AM +0800, Nicolas Boichat wrote:
> > On Fri, Jul 24, 2020 at 8:41 PM Nicolas Boichat <[email protected]> wrote:
> > >
> > > On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman
> > > <[email protected]> wrote:
> > > >
> > > > On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote:
> > > > > trace_printk should not be used in production code, replace it
> > > > > call with pr_info.
> > > > >
> > > > > Signed-off-by: Nicolas Boichat <[email protected]>
> > > > > ---
> > > > > Sent this before as part of a series (whose 4th patch was a
> > > > > change that allows to detect such trace_printk), but maybe it's
> > > > > easier to get individual maintainer attention by splitting it.
> > > >
> > > > Mauro should take this soon:
> > > >
> > > > Acked-by: Greg Kroah-Hartman <[email protected]>
> > >
> > > Mauro: did you get a chance to look at this? (and the other similar
> > > patch "media: camss: vfe: Use trace_printk for debugging only")
> >
> > Mauro: Another gentle ping. Thanks.
>
> It's the middle of the merge window, maintainers can't do anything until
> after 5.9-rc1 is out, sorry.
Huh, wait, looks like Mauro _did_ pick it (found it in this email
"[GIT PULL for v5.8-rc7] media fixes").
My bad then, I was expecting an ack ,-)
Thanks!
> greg k-h
Em Fri, 7 Aug 2020 14:51:12 +0800
Nicolas Boichat <[email protected]> escreveu:
> On Fri, Aug 7, 2020 at 2:28 PM Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > On Fri, Aug 07, 2020 at 09:50:23AM +0800, Nicolas Boichat wrote:
> > > On Fri, Jul 24, 2020 at 8:41 PM Nicolas Boichat <[email protected]> wrote:
> > > >
> > > > On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman
> > > > <[email protected]> wrote:
> > > > >
> > > > > On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote:
> > > > > > trace_printk should not be used in production code, replace it
> > > > > > call with pr_info.
> > > > > >
> > > > > > Signed-off-by: Nicolas Boichat <[email protected]>
> > > > > > ---
> > > > > > Sent this before as part of a series (whose 4th patch was a
> > > > > > change that allows to detect such trace_printk), but maybe it's
> > > > > > easier to get individual maintainer attention by splitting it.
> > > > >
> > > > > Mauro should take this soon:
> > > > >
> > > > > Acked-by: Greg Kroah-Hartman <[email protected]>
> > > >
> > > > Mauro: did you get a chance to look at this? (and the other similar
> > > > patch "media: camss: vfe: Use trace_printk for debugging only")
> > >
> > > Mauro: Another gentle ping. Thanks.
> >
> > It's the middle of the merge window, maintainers can't do anything until
> > after 5.9-rc1 is out, sorry.
>
> Huh, wait, looks like Mauro _did_ pick it (found it in this email
> "[GIT PULL for v5.8-rc7] media fixes").
>
> My bad then, I was expecting an ack ,-)
Never expect acks. Kernel maintainers usually don't send them.
Yet, in the case of media, you should probably have received
an automatic e-mail from our patchwork instance.
Thanks,
Mauro
On Fri, Aug 7, 2020 at 4:04 PM Mauro Carvalho Chehab <[email protected]> wrote:
>
> Em Fri, 7 Aug 2020 14:51:12 +0800
> Nicolas Boichat <[email protected]> escreveu:
>
> > On Fri, Aug 7, 2020 at 2:28 PM Greg Kroah-Hartman
> > <[email protected]> wrote:
> > >
> > > On Fri, Aug 07, 2020 at 09:50:23AM +0800, Nicolas Boichat wrote:
> > > > On Fri, Jul 24, 2020 at 8:41 PM Nicolas Boichat <[email protected]> wrote:
> > > > >
> > > > > On Fri, Jul 10, 2020 at 3:03 PM Greg Kroah-Hartman
> > > > > <[email protected]> wrote:
> > > > > >
> > > > > > On Fri, Jul 10, 2020 at 02:45:29PM +0800, Nicolas Boichat wrote:
> > > > > > > trace_printk should not be used in production code, replace it
> > > > > > > call with pr_info.
> > > > > > >
> > > > > > > Signed-off-by: Nicolas Boichat <[email protected]>
> > > > > > > ---
> > > > > > > Sent this before as part of a series (whose 4th patch was a
> > > > > > > change that allows to detect such trace_printk), but maybe it's
> > > > > > > easier to get individual maintainer attention by splitting it.
> > > > > >
> > > > > > Mauro should take this soon:
> > > > > >
> > > > > > Acked-by: Greg Kroah-Hartman <[email protected]>
> > > > >
> > > > > Mauro: did you get a chance to look at this? (and the other similar
> > > > > patch "media: camss: vfe: Use trace_printk for debugging only")
> > > >
> > > > Mauro: Another gentle ping. Thanks.
> > >
> > > It's the middle of the merge window, maintainers can't do anything until
> > > after 5.9-rc1 is out, sorry.
> >
> > Huh, wait, looks like Mauro _did_ pick it (found it in this email
> > "[GIT PULL for v5.8-rc7] media fixes").
> >
> > My bad then, I was expecting an ack ,-)
>
> Never expect acks. Kernel maintainers usually don't send them.
For some reasons I'm working mainly with maintainers who do ,-) I'll
adjust my expectations, thanks.
> Yet, in the case of media, you should probably have received
> an automatic e-mail from our patchwork instance.
Nope, didn't receive anything. But I'm happy to blame gmail for that...
Anyway, I'll ping you again after the merge window closes about
"media: camss: vfe: Use trace_printk for debugging only" (I _think_
that one didn't get merged). Hopefully not too many other
trace_printks made it through the cracks in the meantime ,-)
Thanks, have a good weekend,
>
> Thanks,
> Mauro