2020-06-15 03:34:55

by Randy Dunlap

Subject: [PATCH] Documentation: fix filesystems/locking.rst malformed table warnings

From: Randy Dunlap <[email protected]>

Fix Sphinx malformed table warnings in filesystems/locking.rst:

lnx-58-rc1/Documentation/filesystems/locking.rst:443: WARNING: Malformed table.
Text in column margin in table line 8.

lnx-58-rc1/Documentation/filesystems/locking.rst:620: WARNING: Malformed table.
Text in column margin in table line 2.

Fixes: ec23eb54fbc7 ("docs: fs: convert docs without extension to ReST")
Fixes: c1e8d7c6a7a6 ("mmap locking API: convert mmap_sem comments")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mauro Carvalho Chehab <[email protected]>
Cc: Michel Lespinasse <[email protected]>
Cc: Andrew Morton <[email protected]>
---
Documentation/filesystems/locking.rst | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

--- lnx-58-rc1.orig/Documentation/filesystems/locking.rst
+++ lnx-58-rc1/Documentation/filesystems/locking.rst
@@ -433,15 +433,15 @@ prototypes::

locking rules:

-========== ============= ================= =========
+====================== ============= ================= =========
ops inode->i_lock blocked_lock_lock may block
-========== ============= ================= =========
+====================== ============= ================= =========
lm_notify: yes yes no
lm_grant: no no no
lm_break: yes no no
lm_change yes no no
lm_breaker_owns_lease: no no no
-========== ============= ================= =========
+====================== ============= ================= =========

buffer_head
===========
@@ -616,9 +616,9 @@ prototypes::

locking rules:

-============= ======== ===========================
+============= ========= ===========================
ops mmap_lock PageLocked(page)
-============= ======== ===========================
+============= ========= ===========================
open: yes
close: yes
fault: yes can return with page locked
@@ -626,7 +626,7 @@ map_pages: yes
page_mkwrite: yes can return with page locked
pfn_mkwrite: yes
access: yes
-============= ======== ===========================
+============= ========= ===========================

->fault() is called when a previously not present pte is about
to be faulted in. The filesystem must find and return the page associated

2020-06-15 04:17:28

by Michel Lespinasse

Subject: Re: [PATCH] Documentation: fix filesystems/locking.rst malformed table warnings

On Sun, Jun 14, 2020 at 8:22 PM Randy Dunlap <[email protected]> wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix Sphinx malformed table warnings in filesystems/locking.rst:
>
> lnx-58-rc1/Documentation/filesystems/locking.rst:443: WARNING: Malformed table.
> Text in column margin in table line 8.
>
> lnx-58-rc1/Documentation/filesystems/locking.rst:620: WARNING: Malformed table.
> Text in column margin in table line 2.
>
> Fixes: ec23eb54fbc7 ("docs: fs: convert docs without extension to ReST")
> Fixes: c1e8d7c6a7a6 ("mmap locking API: convert mmap_sem comments")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Michel Lespinasse <[email protected]>
> Cc: Andrew Morton <[email protected]>

Acked-by: Michel Lespinasse <[email protected]>
Thanks for the fixes !

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

2020-06-20 04:34:10

by Jonathan Corbet

Subject: Re: [PATCH] Documentation: fix filesystems/locking.rst malformed table warnings

On Sun, 14 Jun 2020 20:22:19 -0700
Randy Dunlap <[email protected]> wrote:

> From: Randy Dunlap <[email protected]>
>
> Fix Sphinx malformed table warnings in filesystems/locking.rst:
>
> lnx-58-rc1/Documentation/filesystems/locking.rst:443: WARNING: Malformed table.
> Text in column margin in table line 8.
>
> lnx-58-rc1/Documentation/filesystems/locking.rst:620: WARNING: Malformed table.
> Text in column margin in table line 2.
>
> Fixes: ec23eb54fbc7 ("docs: fs: convert docs without extension to ReST")
> Fixes: c1e8d7c6a7a6 ("mmap locking API: convert mmap_sem comments")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mauro Carvalho Chehab <[email protected]>
> Cc: Michel Lespinasse <[email protected]>
> Cc: Andrew Morton <[email protected]>
> ---
> Documentation/filesystems/locking.rst | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Applied, thanks.

jon