2017-11-04 1:52 GMT+08:00 Jim Mattson <[email protected]>:
> On Thu, Nov 2, 2017 at 5:35 PM, Wanpeng Li <[email protected]> wrote:
>> From: Wanpeng Li <[email protected]>
>>
>> According to the SDM, if the "load IA32_BNDCFGS" VM-entry controls is 1, the
>> following checks are performed on the field for the IA32_BNDCFGS MSR:
>> - Bits reserved in the IA32_BNDCFGS MSR must be 0.
>> - The linear address in bits 63:12 must be canonical.
>>
>> Reviewed-by: Konrad Rzeszutek Wilk <[email protected]>
>> Cc: Paolo Bonzini <[email protected]>
>> Cc: Radim Krčmář <[email protected]>
>> Cc: Jim Mattson <[email protected]>
>> Signed-off-by: Wanpeng Li <[email protected]>
>> ---
>> v3 -> v4:
>> * simply condition
>> * use && instead of nested "if"s
>>
>> arch/x86/kvm/vmx.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index e6c8ffa..6cf3972 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -10805,6 +10805,11 @@ static int check_vmentry_postreqs(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
>> return 1;
>> }
>>
>> + if (kvm_mpx_supported() &&
>
> I think you kept the wrong conjunct from the previous version. Drop
> kvm_mpx_supported() and restore the test for
> (vmcs12->vm_entry_controls & VM_ENTRY_LOAD_BNDCFGS).
Yeah, I misunderstand the English.
Regards,
Wanpeng Li
From 1583068486025388850@xxx Fri Nov 03 17:55:56 +0000 2017
X-GM-THRID: 1583003090430485903
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread