2022-10-02 18:08:36

by Wilken Gottwalt

[permalink] [raw]
Subject: [PATCH] hwmon: corsair-psu: add USB id of new revision of the HX1000i psu

Also updates the documentation accordingly.

Signed-off-by: Wilken Gottwalt <[email protected]>
---
Documentation/hwmon/corsair-psu.rst | 2 +-
drivers/hwmon/corsair-psu.c | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Documentation/hwmon/corsair-psu.rst b/Documentation/hwmon/corsair-psu.rst
index c3a76305c587..3c1b164eb3c0 100644
--- a/Documentation/hwmon/corsair-psu.rst
+++ b/Documentation/hwmon/corsair-psu.rst
@@ -15,7 +15,7 @@ Supported devices:

Corsair HX850i

- Corsair HX1000i
+ Corsair HX1000i (revision 1 and 2)

Corsair HX1200i

diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
index c99e4c6afc2d..345d883ab044 100644
--- a/drivers/hwmon/corsair-psu.c
+++ b/drivers/hwmon/corsair-psu.c
@@ -813,13 +813,14 @@ static const struct hid_device_id corsairpsu_idtable[] = {
{ HID_USB_DEVICE(0x1b1c, 0x1c04) }, /* Corsair HX650i */
{ HID_USB_DEVICE(0x1b1c, 0x1c05) }, /* Corsair HX750i */
{ HID_USB_DEVICE(0x1b1c, 0x1c06) }, /* Corsair HX850i */
- { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i */
+ { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i revision 1 */
{ HID_USB_DEVICE(0x1b1c, 0x1c08) }, /* Corsair HX1200i */
{ HID_USB_DEVICE(0x1b1c, 0x1c09) }, /* Corsair RM550i */
{ HID_USB_DEVICE(0x1b1c, 0x1c0a) }, /* Corsair RM650i */
{ HID_USB_DEVICE(0x1b1c, 0x1c0b) }, /* Corsair RM750i */
{ HID_USB_DEVICE(0x1b1c, 0x1c0c) }, /* Corsair RM850i */
{ HID_USB_DEVICE(0x1b1c, 0x1c0d) }, /* Corsair RM1000i */
+ { HID_USB_DEVICE(0x1b1c, 0x1c1e) }, /* Corsaur HX1000i revision 2 */
{ },
};
MODULE_DEVICE_TABLE(hid, corsairpsu_idtable);
--
2.37.3


2022-10-02 22:07:52

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH] hwmon: corsair-psu: add USB id of new revision of the HX1000i psu

On Sun, Oct 02, 2022 at 05:45:53PM +0000, Wilken Gottwalt wrote:
> Also updates the documentation accordingly.
>
> Signed-off-by: Wilken Gottwalt <[email protected]>

Applied.

Thanks,
Guenter

> ---
> Documentation/hwmon/corsair-psu.rst | 2 +-
> drivers/hwmon/corsair-psu.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/hwmon/corsair-psu.rst b/Documentation/hwmon/corsair-psu.rst
> index c3a76305c587..3c1b164eb3c0 100644
> --- a/Documentation/hwmon/corsair-psu.rst
> +++ b/Documentation/hwmon/corsair-psu.rst
> @@ -15,7 +15,7 @@ Supported devices:
>
> Corsair HX850i
>
> - Corsair HX1000i
> + Corsair HX1000i (revision 1 and 2)
>
> Corsair HX1200i
>
> diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> index c99e4c6afc2d..345d883ab044 100644
> --- a/drivers/hwmon/corsair-psu.c
> +++ b/drivers/hwmon/corsair-psu.c
> @@ -813,13 +813,14 @@ static const struct hid_device_id corsairpsu_idtable[] = {
> { HID_USB_DEVICE(0x1b1c, 0x1c04) }, /* Corsair HX650i */
> { HID_USB_DEVICE(0x1b1c, 0x1c05) }, /* Corsair HX750i */
> { HID_USB_DEVICE(0x1b1c, 0x1c06) }, /* Corsair HX850i */
> - { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i */
> + { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i revision 1 */
> { HID_USB_DEVICE(0x1b1c, 0x1c08) }, /* Corsair HX1200i */
> { HID_USB_DEVICE(0x1b1c, 0x1c09) }, /* Corsair RM550i */
> { HID_USB_DEVICE(0x1b1c, 0x1c0a) }, /* Corsair RM650i */
> { HID_USB_DEVICE(0x1b1c, 0x1c0b) }, /* Corsair RM750i */
> { HID_USB_DEVICE(0x1b1c, 0x1c0c) }, /* Corsair RM850i */
> { HID_USB_DEVICE(0x1b1c, 0x1c0d) }, /* Corsair RM1000i */
> + { HID_USB_DEVICE(0x1b1c, 0x1c1e) }, /* Corsaur HX1000i revision 2 */
> { },
> };
> MODULE_DEVICE_TABLE(hid, corsairpsu_idtable);

2022-10-03 09:06:25

by Jonas Malaco

[permalink] [raw]
Subject: Re: [PATCH] hwmon: corsair-psu: add USB id of new revision of the HX1000i psu

On Sun, Oct 2, 2022 at 2:46 PM Wilken Gottwalt
<[email protected]> wrote:
>
> Also updates the documentation accordingly.
>
> Signed-off-by: Wilken Gottwalt <[email protected]>
> ---
> Documentation/hwmon/corsair-psu.rst | 2 +-
> drivers/hwmon/corsair-psu.c | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/hwmon/corsair-psu.rst b/Documentation/hwmon/corsair-psu.rst
> index c3a76305c587..3c1b164eb3c0 100644
> --- a/Documentation/hwmon/corsair-psu.rst
> +++ b/Documentation/hwmon/corsair-psu.rst
> @@ -15,7 +15,7 @@ Supported devices:
>
> Corsair HX850i
>
> - Corsair HX1000i
> + Corsair HX1000i (revision 1 and 2)
>
> Corsair HX1200i
>
> diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> index c99e4c6afc2d..345d883ab044 100644
> --- a/drivers/hwmon/corsair-psu.c
> +++ b/drivers/hwmon/corsair-psu.c
> @@ -813,13 +813,14 @@ static const struct hid_device_id corsairpsu_idtable[] = {
> { HID_USB_DEVICE(0x1b1c, 0x1c04) }, /* Corsair HX650i */
> { HID_USB_DEVICE(0x1b1c, 0x1c05) }, /* Corsair HX750i */
> { HID_USB_DEVICE(0x1b1c, 0x1c06) }, /* Corsair HX850i */
> - { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i */
> + { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i revision 1 */
> { HID_USB_DEVICE(0x1b1c, 0x1c08) }, /* Corsair HX1200i */
> { HID_USB_DEVICE(0x1b1c, 0x1c09) }, /* Corsair RM550i */
> { HID_USB_DEVICE(0x1b1c, 0x1c0a) }, /* Corsair RM650i */
> { HID_USB_DEVICE(0x1b1c, 0x1c0b) }, /* Corsair RM750i */
> { HID_USB_DEVICE(0x1b1c, 0x1c0c) }, /* Corsair RM850i */
> { HID_USB_DEVICE(0x1b1c, 0x1c0d) }, /* Corsair RM1000i */
> + { HID_USB_DEVICE(0x1b1c, 0x1c1e) }, /* Corsaur HX1000i revision 2 */

Wilken,

A small typo has creeped in: s/Corsaur/Corsair/.

P.S. Sorry if this reply arrives somewhat mangled, I'm away from my
regular setup.

> { },
> };
> MODULE_DEVICE_TABLE(hid, corsairpsu_idtable);
> --
> 2.37.3
>

2022-10-03 09:31:10

by Wilken Gottwalt

[permalink] [raw]
Subject: Re: [PATCH] hwmon: corsair-psu: add USB id of new revision of the HX1000i psu

On Mon, 3 Oct 2022 05:13:27 -0300
Jonas Malaco <[email protected]> wrote:

> On Sun, Oct 2, 2022 at 2:46 PM Wilken Gottwalt
> <[email protected]> wrote:
> >
> > Also updates the documentation accordingly.
> >
> > Signed-off-by: Wilken Gottwalt <[email protected]>
> > ---
> > Documentation/hwmon/corsair-psu.rst | 2 +-
> > drivers/hwmon/corsair-psu.c | 3 ++-
> > 2 files changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/hwmon/corsair-psu.rst b/Documentation/hwmon/corsair-psu.rst
> > index c3a76305c587..3c1b164eb3c0 100644
> > --- a/Documentation/hwmon/corsair-psu.rst
> > +++ b/Documentation/hwmon/corsair-psu.rst
> > @@ -15,7 +15,7 @@ Supported devices:
> >
> > Corsair HX850i
> >
> > - Corsair HX1000i
> > + Corsair HX1000i (revision 1 and 2)
> >
> > Corsair HX1200i
> >
> > diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c
> > index c99e4c6afc2d..345d883ab044 100644
> > --- a/drivers/hwmon/corsair-psu.c
> > +++ b/drivers/hwmon/corsair-psu.c
> > @@ -813,13 +813,14 @@ static const struct hid_device_id corsairpsu_idtable[] = {
> > { HID_USB_DEVICE(0x1b1c, 0x1c04) }, /* Corsair HX650i */
> > { HID_USB_DEVICE(0x1b1c, 0x1c05) }, /* Corsair HX750i */
> > { HID_USB_DEVICE(0x1b1c, 0x1c06) }, /* Corsair HX850i */
> > - { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i */
> > + { HID_USB_DEVICE(0x1b1c, 0x1c07) }, /* Corsair HX1000i revision 1 */
> > { HID_USB_DEVICE(0x1b1c, 0x1c08) }, /* Corsair HX1200i */
> > { HID_USB_DEVICE(0x1b1c, 0x1c09) }, /* Corsair RM550i */
> > { HID_USB_DEVICE(0x1b1c, 0x1c0a) }, /* Corsair RM650i */
> > { HID_USB_DEVICE(0x1b1c, 0x1c0b) }, /* Corsair RM750i */
> > { HID_USB_DEVICE(0x1b1c, 0x1c0c) }, /* Corsair RM850i */
> > { HID_USB_DEVICE(0x1b1c, 0x1c0d) }, /* Corsair RM1000i */
> > + { HID_USB_DEVICE(0x1b1c, 0x1c1e) }, /* Corsaur HX1000i revision 2 */
>
> Wilken,
>
> A small typo has creeped in: s/Corsaur/Corsair/.
>
> P.S. Sorry if this reply arrives somewhat mangled, I'm away from my
> regular setup.

Oh, looks like I hit one key next to it. Thx for spotting this.

greetings,
Will