2023-05-31 09:18:18

by Zong Li

[permalink] [raw]
Subject: [PATCH v3] dmaengine: xilinx: dma: remove arch dependency

As following patches, xilinx dma is also now architecture agnostic,
and it can be compiled for several architectures. We have verified the
CDMA on RISC-V platform, let's remove the ARCH dependency list instead
of adding new ARCH.

To avoid breaking the s390 build, add a dependency on HAS_IOMEM.

'e8b6c54f6d57 ("net: xilinx: temac: Relax Kconfig dependencies")'
'd7eaf962a90b ("net: axienet: In kconfig remove arch dependency for axi_emac")'

Signed-off-by: Zong Li <[email protected]>
Acked-by: Palmer Dabbelt <[email protected]>
Suggested-by: Radhey Shyam Pandey <[email protected]>
Reported-by: kernel test robot <[email protected]>
---

Changes in v3:
- Add a dependency on HAS_IOMEM to avoid breaking the s390 build

Changes in v2:
- Remove ARCH dependency list instead of adding new ARCH

drivers/dma/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index f5f422f9b850..fd5a94e67163 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -696,7 +696,7 @@ config XGENE_DMA

config XILINX_DMA
tristate "Xilinx AXI DMAS Engine"
- depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
+ depends on HAS_IOMEM
select DMA_ENGINE
help
Enable support for Xilinx AXI VDMA Soft IP.
--
2.17.1



2023-06-26 03:55:39

by Zong Li

[permalink] [raw]
Subject: Re: [PATCH v3] dmaengine: xilinx: dma: remove arch dependency

On Wed, May 31, 2023 at 5:01 PM Zong Li <[email protected]> wrote:
>
> As following patches, xilinx dma is also now architecture agnostic,
> and it can be compiled for several architectures. We have verified the
> CDMA on RISC-V platform, let's remove the ARCH dependency list instead
> of adding new ARCH.
>
> To avoid breaking the s390 build, add a dependency on HAS_IOMEM.
>
> 'e8b6c54f6d57 ("net: xilinx: temac: Relax Kconfig dependencies")'
> 'd7eaf962a90b ("net: axienet: In kconfig remove arch dependency for axi_emac")'
>
> Signed-off-by: Zong Li <[email protected]>
> Acked-by: Palmer Dabbelt <[email protected]>
> Suggested-by: Radhey Shyam Pandey <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> ---
>
> Changes in v3:
> - Add a dependency on HAS_IOMEM to avoid breaking the s390 build
>
> Changes in v2:
> - Remove ARCH dependency list instead of adding new ARCH
>
> drivers/dma/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index f5f422f9b850..fd5a94e67163 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -696,7 +696,7 @@ config XGENE_DMA
>
> config XILINX_DMA
> tristate "Xilinx AXI DMAS Engine"
> - depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> + depends on HAS_IOMEM
> select DMA_ENGINE
> help
> Enable support for Xilinx AXI VDMA Soft IP.
> --
> 2.17.1
>

Hi Vinod,
Linux 6.5-rc1 is opening, could I know if this patch is good for you?
Would it be considered in this merge window?
Thanks.

2023-07-10 02:47:11

by Zong Li

[permalink] [raw]
Subject: Re: [PATCH v3] dmaengine: xilinx: dma: remove arch dependency

On Mon, Jun 26, 2023 at 10:54 AM Zong Li <[email protected]> wrote:
>
> On Wed, May 31, 2023 at 5:01 PM Zong Li <[email protected]> wrote:
> >
> > As following patches, xilinx dma is also now architecture agnostic,
> > and it can be compiled for several architectures. We have verified the
> > CDMA on RISC-V platform, let's remove the ARCH dependency list instead
> > of adding new ARCH.
> >
> > To avoid breaking the s390 build, add a dependency on HAS_IOMEM.
> >
> > 'e8b6c54f6d57 ("net: xilinx: temac: Relax Kconfig dependencies")'
> > 'd7eaf962a90b ("net: axienet: In kconfig remove arch dependency for axi_emac")'
> >
> > Signed-off-by: Zong Li <[email protected]>
> > Acked-by: Palmer Dabbelt <[email protected]>
> > Suggested-by: Radhey Shyam Pandey <[email protected]>
> > Reported-by: kernel test robot <[email protected]>
> > ---
> >
> > Changes in v3:
> > - Add a dependency on HAS_IOMEM to avoid breaking the s390 build
> >
> > Changes in v2:
> > - Remove ARCH dependency list instead of adding new ARCH
> >
> > drivers/dma/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index f5f422f9b850..fd5a94e67163 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -696,7 +696,7 @@ config XGENE_DMA
> >
> > config XILINX_DMA
> > tristate "Xilinx AXI DMAS Engine"
> > - depends on (ARCH_ZYNQ || MICROBLAZE || ARM64)
> > + depends on HAS_IOMEM
> > select DMA_ENGINE
> > help
> > Enable support for Xilinx AXI VDMA Soft IP.
> > --
> > 2.17.1
> >
>
> Hi Vinod,
> Linux 6.5-rc1 is opening, could I know if this patch is good for you?
> Would it be considered in this merge window?
> Thanks.

Hi Vinod,
It seems that we are transitioning to Linux v6.5-rc2. I'm uncertain
whether you consider this a new feature or a fix. Is there a
possibility of incorporating it during this cycle? Thank you.

2023-07-11 17:08:25

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v3] dmaengine: xilinx: dma: remove arch dependency


On Wed, 31 May 2023 09:01:41 +0000, Zong Li wrote:
> As following patches, xilinx dma is also now architecture agnostic,
> and it can be compiled for several architectures. We have verified the
> CDMA on RISC-V platform, let's remove the ARCH dependency list instead
> of adding new ARCH.
>
> To avoid breaking the s390 build, add a dependency on HAS_IOMEM.
>
> [...]

Applied, thanks!

[1/1] dmaengine: xilinx: dma: remove arch dependency
commit: 9945a80fe40886f2d0655c0c3cdee95aaecafb87

Best regards,
--
~Vinod