unsigned long value is never < 0
Cc: Doug Thompson <[email protected]>
Cc: Borislav Petkov <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/edac/edac_module.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/edac_module.c b/drivers/edac/edac_module.c
index a66941f..e6d1691 100644
--- a/drivers/edac/edac_module.c
+++ b/drivers/edac/edac_module.c
@@ -28,7 +28,7 @@ static int edac_set_debug_level(const char *buf, struct kernel_param *kp)
if (ret)
return ret;
- if (val < 0 || val > 4)
+ if (val > 4)
return -EINVAL;
return param_set_int(buf, kp);
--
1.8.4.5
On Mon, Jun 09, 2014 at 09:20:18PM +0200, Fabian Frederick wrote:
> unsigned long value is never < 0
>
> Cc: Doug Thompson <[email protected]>
> Cc: Borislav Petkov <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> drivers/edac/edac_module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/edac/edac_module.c b/drivers/edac/edac_module.c
> index a66941f..e6d1691 100644
> --- a/drivers/edac/edac_module.c
> +++ b/drivers/edac/edac_module.c
> @@ -28,7 +28,7 @@ static int edac_set_debug_level(const char *buf, struct kernel_param *kp)
> if (ret)
> return ret;
>
> - if (val < 0 || val > 4)
> + if (val > 4)
> return -EINVAL;
Ok, so I don't know how you caught this but FWIW, we have those W= build
switches which trigger it too (which is a good thing that we have them
:-))
$ make W=1 drivers/edac/edac_module.o
...
drivers/edac/edac_module.c: In function ‘edac_set_debug_level’:
drivers/edac/edac_module.c:31:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (val < 0 || val > 4)
Applied, thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
2014-06-10 21:27 GMT+03:00 Borislav Petkov <[email protected]>:
> On Mon, Jun 09, 2014 at 09:20:18PM +0200, Fabian Frederick wrote:
>> unsigned long value is never < 0
>>
>> Cc: Doug Thompson <[email protected]>
>> Cc: Borislav Petkov <[email protected]>
>> Signed-off-by: Fabian Frederick <[email protected]>
>> ---
>> drivers/edac/edac_module.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/edac/edac_module.c b/drivers/edac/edac_module.c
>> index a66941f..e6d1691 100644
>> --- a/drivers/edac/edac_module.c
>> +++ b/drivers/edac/edac_module.c
>> @@ -28,7 +28,7 @@ static int edac_set_debug_level(const char *buf, struct kernel_param *kp)
>> if (ret)
>> return ret;
>>
>> - if (val < 0 || val > 4)
>> + if (val > 4)
>> return -EINVAL;
>
> Ok, so I don't know how you caught this but FWIW, we have those W= build
> switches which trigger it too (which is a good thing that we have them
> :-))
>
> $ make W=1 drivers/edac/edac_module.o
>
> ...
>
> drivers/edac/edac_module.c: In function 'edac_set_debug_level':
> drivers/edac/edac_module.c:31:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> if (val < 0 || val > 4)
>
> Applied, thanks.
This hasn't got into none of v3.16-rc5 release, repos "linux-stable"
and "torvalds/linux".
See https://bugzilla.kernel.org/show_bug.cgi?id=80431
--
Andrey Utkin
On Thu, Jul 17, 2014 at 03:26:26PM +0300, Andrey Utkin wrote:
> This hasn't got into none of v3.16-rc5 release, repos "linux-stable"
> and "torvalds/linux".
> See https://bugzilla.kernel.org/show_bug.cgi?id=80431
It is queued for 3.17 and it won't get into stable because it doesn't
fit stable rules.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--