2023-01-10 22:17:21

by Vipin Sharma

Subject: [Patch] KVM: selftests: Make reclaim_period_ms input always be positive

reclaim_period_ms used to be positive only but the commit 0001725d0f9b
("KVM: selftests: Add atoi_positive() and atoi_non_negative() for input
validation") incorrectly changed it to non-negative validation.

Change validation to allow only positive input.

Signed-off-by: Vipin Sharma <[email protected]>
Reported-by: Ben Gardon <[email protected]>
---
tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c b/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
index ea0978f22db8..251794f83719 100644
--- a/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
+++ b/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
@@ -241,7 +241,7 @@ int main(int argc, char **argv)
while ((opt = getopt(argc, argv, "hp:t:r")) != -1) {
switch (opt) {
case 'p':
- reclaim_period_ms = atoi_non_negative("Reclaim period", optarg);
+ reclaim_period_ms = atoi_positive("Reclaim period", optarg);
break;
case 't':
token = atoi_paranoid(optarg);
--
2.39.0.314.g84b9a713c41-goog

2023-01-10 22:47:09

by Ben Gardon

Subject: Re: [Patch] KVM: selftests: Make reclaim_period_ms input always be positive

On Tue, Jan 10, 2023 at 1:52 PM Vipin Sharma <[email protected]> wrote:
>
> reclaim_period_ms used to be positive only but the commit 0001725d0f9b
> ("KVM: selftests: Add atoi_positive() and atoi_non_negative() for input
> validation") incorrectly changed it to non-negative validation.
>
> Change validation to allow only positive input.
>
> Signed-off-by: Vipin Sharma <[email protected]>
> Reported-by: Ben Gardon <[email protected]>

Please add a Fixes: tag:
Fixes: 0001725d0f9b ("KVM: selftests: Add atoi_positive() and
atoi_non_negative() for input validation")

But otherwise,
Reviewed-by: Ben Gardon <[email protected]>

> ---
> tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c b/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
> index ea0978f22db8..251794f83719 100644
> --- a/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
> @@ -241,7 +241,7 @@ int main(int argc, char **argv)
> while ((opt = getopt(argc, argv, "hp:t:r")) != -1) {
> switch (opt) {
> case 'p':
> - reclaim_period_ms = atoi_non_negative("Reclaim period", optarg);
> + reclaim_period_ms = atoi_positive("Reclaim period", optarg);
> break;
> case 't':
> token = atoi_paranoid(optarg);
> --
> 2.39.0.314.g84b9a713c41-goog
>

2023-01-11 01:09:10

by Vipin Sharma

Subject: Re: [Patch] KVM: selftests: Make reclaim_period_ms input always be positive

On Tue, Jan 10, 2023 at 2:19 PM Ben Gardon <[email protected]> wrote:
>
> On Tue, Jan 10, 2023 at 1:52 PM Vipin Sharma <[email protected]> wrote:
> >
> > reclaim_period_ms used to be positive only but the commit 0001725d0f9b
> > ("KVM: selftests: Add atoi_positive() and atoi_non_negative() for input
> > validation") incorrectly changed it to non-negative validation.
> >
> > Change validation to allow only positive input.
> >
> > Signed-off-by: Vipin Sharma <[email protected]>
> > Reported-by: Ben Gardon <[email protected]>
>
> Please add a Fixes: tag:
> Fixes: 0001725d0f9b ("KVM: selftests: Add atoi_positive() and
> atoi_non_negative() for input validation")

Forgot this, I will send v2. Thanks.

>
> But otherwise,
> Reviewed-by: Ben Gardon <[email protected]>
>
> > ---
> > tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c b/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
> > index ea0978f22db8..251794f83719 100644
> > --- a/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
> > +++ b/tools/testing/selftests/kvm/x86_64/nx_huge_pages_test.c
> > @@ -241,7 +241,7 @@ int main(int argc, char **argv)
> > while ((opt = getopt(argc, argv, "hp:t:r")) != -1) {
> > switch (opt) {
> > case 'p':
> > - reclaim_period_ms = atoi_non_negative("Reclaim period", optarg);
> > + reclaim_period_ms = atoi_positive("Reclaim period", optarg);
> > break;
> > case 't':
> > token = atoi_paranoid(optarg);
> > --
> > 2.39.0.314.g84b9a713c41-goog
> >