2023-01-28 07:23:55

by Boqun Feng

[permalink] [raw]
Subject: [PATCH v2] rust: MAINTAINERS: Add the zulip link

Zulip organization "rust-for-linux" has been created since about 2 years
ago[1], and proven to be a great place for Rust related discussion,
therefore add the information in MAINTAINERS file so that newcomers have
more options to find guide and help.

[1]: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/

Signed-off-by: Boqun Feng <[email protected]>
---
v1 -> v2:

* As suggested by Greg KH, add commit message.

MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 42fc47c6edfd..30161207f365 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18219,6 +18219,7 @@ R: Boqun Feng <[email protected]>
R: Gary Guo <[email protected]>
R: Björn Roy Baron <[email protected]>
L: [email protected]
+C: zulip://rust-for-linux.zulipchat.com
S: Supported
W: https://github.com/Rust-for-Linux/linux
B: https://github.com/Rust-for-Linux/linux/issues
--
2.39.1



2023-01-28 10:29:13

by Vincenzo Palazzo

[permalink] [raw]
Subject: Re: [PATCH v2] rust: MAINTAINERS: Add the zulip link

Reviewed-by: Vincenzo Palazzo <[email protected]>

On Sat Jan 28, 2023 at 8:22 AM CET, Boqun Feng wrote:
> Zulip organization "rust-for-linux" has been created since about 2 years
> ago[1], and proven to be a great place for Rust related discussion,
> therefore add the information in MAINTAINERS file so that newcomers have
> more options to find guide and help.
>
> [1]: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/
>
> Signed-off-by: Boqun Feng <[email protected]>
> ---
> v1 -> v2:
>
> * As suggested by Greg KH, add commit message.
>
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42fc47c6edfd..30161207f365 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18219,6 +18219,7 @@ R: Boqun Feng <[email protected]>
> R: Gary Guo <[email protected]>
> R: Björn Roy Baron <[email protected]>
> L: [email protected]
> +C: zulip://rust-for-linux.zulipchat.com
> S: Supported
> W: https://github.com/Rust-for-Linux/linux
> B: https://github.com/Rust-for-Linux/linux/issues
> --
> 2.39.1


2023-02-01 01:38:44

by Miguel Ojeda

[permalink] [raw]
Subject: Re: [PATCH v2] rust: MAINTAINERS: Add the zulip link

On Sat, Jan 28, 2023 at 8:23 AM Boqun Feng <[email protected]> wrote:
>
> Zulip organization "rust-for-linux" has been created since about 2 years

"was created about 2 years ago ... and has proven" maybe?

> [1]: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/

We typically do links as a tag, like:

Link: https://..../ [1]

> R: Gary Guo <[email protected]>
> R: Björn Roy Baron <[email protected]>
> L: [email protected]
> +C: zulip://rust-for-linux.zulipchat.com
> S: Supported
> W: https://github.com/Rust-for-Linux/linux
> B: https://github.com/Rust-for-Linux/linux/issues

The preferred order according to the top of the file is `C:` after
`B:` -- could you please move it? (even if not everybody follows it)

Thanks Boqun!

Also, for reference for others: a few of us discussed a bit in Zulip
whether to use `zulip://` or `https://` here: `zulip://` hints at the
fact that it is possible to join with apps/clients and not just with a
web browser, which is why Boqun wants to use this one. Support for the
URI scheme in place of the `https://` one isn't great in some of the
apps, though, so I worried it could be confusing.

Hopefully the URI scheme support will improve in the future. So let's
try `zulip://` -- it may help getting better support for that URI
scheme too :)

Cheers,
Miguel

2023-02-01 18:46:37

by Boqun Feng

[permalink] [raw]
Subject: [PATCH v3] rust: MAINTAINERS: Add the zulip link

Zulip organization "rust-for-linux" was created 2 years ago[1] and has
proven to be a great place for Rust related discussion, therefore
add the information in MAINTAINERS file so that newcomers have more
options to find guide and help.

Link: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/ [1]
Signed-off-by: Boqun Feng <[email protected]>
---
v2 -> v3:

* Commit message improvement per Miguel.
* Reorder the line after "B:" as suggested by Miguel.

v1 -> v2:

* As suggested by Greg KH, add commit message.
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 42fc47c6edfd..80fc5f050f28 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18222,6 +18222,7 @@ L: [email protected]
S: Supported
W: https://github.com/Rust-for-Linux/linux
B: https://github.com/Rust-for-Linux/linux/issues
+C: zulip://rust-for-linux.zulipchat.com
T: git https://github.com/Rust-for-Linux/linux.git rust-next
F: Documentation/rust/
F: rust/
--
2.39.1


2023-02-01 22:51:15

by Miguel Ojeda

[permalink] [raw]
Subject: Re: [PATCH v3] rust: MAINTAINERS: Add the zulip link

On Wed, Feb 1, 2023 at 7:46 PM Boqun Feng <[email protected]> wrote:
>
> Zulip organization "rust-for-linux" was created 2 years ago[1] and has
> proven to be a great place for Rust related discussion, therefore
> add the information in MAINTAINERS file so that newcomers have more
> options to find guide and help.
>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/ [1]
> Signed-off-by: Boqun Feng <[email protected]>

Applied to rust-next, thanks Boqun!

(Vincenzo: if you would like me to apply your tag to v3, please let me know.)

Cheers,
Miguel

2023-02-02 07:27:19

by Vincenzo Palazzo

[permalink] [raw]
Subject: Re: [PATCH v3] rust: MAINTAINERS: Add the zulip link

On Wed Feb 1, 2023 at 7:45 PM CET, Boqun Feng wrote:
> Zulip organization "rust-for-linux" was created 2 years ago[1] and has
> proven to be a great place for Rust related discussion, therefore
> add the information in MAINTAINERS file so that newcomers have more
> options to find guide and help.
>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/ [1]
> Signed-off-by: Boqun Feng <[email protected]>
> ---
Reviewed-by: Vincenzo Palazzo <[email protected]>


> v2 -> v3:
>
> * Commit message improvement per Miguel.
> * Reorder the line after "B:" as suggested by Miguel.
>
> v1 -> v2:
>
> * As suggested by Greg KH, add commit message.
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42fc47c6edfd..80fc5f050f28 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18222,6 +18222,7 @@ L: [email protected]
> S: Supported
> W: https://github.com/Rust-for-Linux/linux
> B: https://github.com/Rust-for-Linux/linux/issues
> +C: zulip://rust-for-linux.zulipchat.com
> T: git https://github.com/Rust-for-Linux/linux.git rust-next
> F: Documentation/rust/
> F: rust/
> --
> 2.39.1


2023-02-02 08:46:35

by Alice Ferrazzi

[permalink] [raw]
Subject: Re: [PATCH v2] rust: MAINTAINERS: Add the zulip link

On Sat, Jan 28, 2023 at 4:23 PM Boqun Feng <[email protected]> wrote:
>
> Zulip organization "rust-for-linux" has been created since about 2 years
> ago[1], and proven to be a great place for Rust related discussion,
> therefore add the information in MAINTAINERS file so that newcomers have
> more options to find guide and help.
>
> [1]: https://lore.kernel.org/rust-for-linux/CANiq72=xVaMQkgCA9rspjV8bhWDGqAn4x78B0_4U1WBJYj1PiA@mail.gmail.com/
>
> Signed-off-by: Boqun Feng <[email protected]>
> ---
> v1 -> v2:
>
> * As suggested by Greg KH, add commit message.
>
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 42fc47c6edfd..30161207f365 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18219,6 +18219,7 @@ R: Boqun Feng <[email protected]>
> R: Gary Guo <[email protected]>
> R: Björn Roy Baron <[email protected]>
> L: [email protected]
> +C: zulip://rust-for-linux.zulipchat.com
> S: Supported
> W: https://github.com/Rust-for-Linux/linux
> B: https://github.com/Rust-for-Linux/linux/issues
> --
> 2.39.1
>

Looks ok also for me to try out the zulip:// URI scheme.

Reviewed-by: Alice Ferrazzi <[email protected]>

--
======================================
Cybertrust Japan Co.,Ltd.
Alice Ferrazzi
[email protected]
======================================