2021-09-28 19:09:27

by Mianhan Liu

Subject: [PATCH -next] drivers/auxdisplay//ks0108.c: remove superfluous header files from ks0108.c

ks0108.c hasn't use any macro or function declared in linux/fs.h,
linux/io.h and linux/uaccess.h.
Thus, these files can be removed from ks0108.c safely without
affecting the compilation of the drivers/auxdisplay/ module

Signed-off-by: Mianhan Liu <[email protected]>

---
drivers/auxdisplay/ks0108.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/auxdisplay/ks0108.c b/drivers/auxdisplay/ks0108.c
index e871b94a1..234f9dbe6 100644
--- a/drivers/auxdisplay/ks0108.c
+++ b/drivers/auxdisplay/ks0108.c
@@ -15,10 +15,7 @@
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/delay.h>
-#include <linux/fs.h>
-#include <linux/io.h>
#include <linux/parport.h>
-#include <linux/uaccess.h>
#include <linux/ks0108.h>

#define KS0108_NAME "ks0108"
--
2.25.1

2021-10-21 22:12:32

by Miguel Ojeda

Subject: Re: [PATCH -next] drivers/auxdisplay//ks0108.c: remove superfluous header files from ks0108.c

On Tue, Sep 28, 2021 at 9:09 PM Mianhan Liu <[email protected]> wrote:
>
> ks0108.c hasn't use any macro or function declared in linux/fs.h,
> linux/io.h and linux/uaccess.h.
> Thus, these files can be removed from ks0108.c safely without
> affecting the compilation of the drivers/auxdisplay/ module

Applied, thanks!

Cheers,
Miguel