2018-01-18 20:18:53

by Corentin Labbe

Subject: [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON

img-ascii-lcd select un-existing SYSCON kconfig name.
This patch fix this error by using the correct MFD_SYSCON kconfig name.

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/auxdisplay/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index 2c2ed9cf8796..d9ab60ed6c9b 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -138,7 +138,7 @@ config IMG_ASCII_LCD
tristate "Imagination Technologies ASCII LCD Display"
depends on HAS_IOMEM
default y if MIPS_MALTA || MIPS_SEAD3
- select SYSCON
+ select MFD_SYSCON
help
Enable this to support the simple ASCII LCD displays found on
development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
--
2.13.6

2018-02-08 16:00:42

by Miguel Ojeda

Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON

On Thu, Jan 18, 2018 at 9:13 PM, Corentin Labbe
<[email protected]> wrote:
> img-ascii-lcd select un-existing SYSCON kconfig name.
> This patch fix this error by using the correct MFD_SYSCON kconfig name.
>

CC'ing Paul & Ralf in case they want to ack.

The mistake seems to be in the tree since the addition of the driver
in 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII
LCD displays").

Acked-by: Miguel Ojeda <[email protected]>

Thanks,
Miguel

> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> drivers/auxdisplay/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index 2c2ed9cf8796..d9ab60ed6c9b 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -138,7 +138,7 @@ config IMG_ASCII_LCD
> tristate "Imagination Technologies ASCII LCD Display"
> depends on HAS_IOMEM
> default y if MIPS_MALTA || MIPS_SEAD3
> - select SYSCON
> + select MFD_SYSCON
> help
> Enable this to support the simple ASCII LCD displays found on
> development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
> --
> 2.13.6
>

2018-02-12 14:49:57

by Miguel Ojeda

Subject: Re: [PATCH] auxdisplay: img-ascii-lcd: fix typo on select SYSCON/MFD_SYSCON

On Thu, Feb 8, 2018 at 4:58 PM, Miguel Ojeda
<[email protected]> wrote:
> On Thu, Jan 18, 2018 at 9:13 PM, Corentin Labbe
> <[email protected]> wrote:
>> img-ascii-lcd select un-existing SYSCON kconfig name.
>> This patch fix this error by using the correct MFD_SYSCON kconfig name.
>>
>
> CC'ing Paul & Ralf in case they want to ack.
>
> The mistake seems to be in the tree since the addition of the driver
> in 0cad855fbd08 ("auxdisplay: img-ascii-lcd: driver for simple ASCII
> LCD displays").
>
> Acked-by: Miguel Ojeda <[email protected]>
>

I will pick this one up in my queue.

> Thanks,
> Miguel
>
>> Signed-off-by: Corentin Labbe <[email protected]>
>> ---
>> drivers/auxdisplay/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
>> index 2c2ed9cf8796..d9ab60ed6c9b 100644
>> --- a/drivers/auxdisplay/Kconfig
>> +++ b/drivers/auxdisplay/Kconfig
>> @@ -138,7 +138,7 @@ config IMG_ASCII_LCD
>> tristate "Imagination Technologies ASCII LCD Display"
>> depends on HAS_IOMEM
>> default y if MIPS_MALTA || MIPS_SEAD3
>> - select SYSCON
>> + select MFD_SYSCON
>> help
>> Enable this to support the simple ASCII LCD displays found on
>> development boards such as the MIPS Boston, MIPS Malta & MIPS SEAD3
>> --
>> 2.13.6
>>