2020-11-14 08:15:44

by Zou Wei

Subject: [PATCH -next] auxdisplay: fix platform_no_drv_owner.cocci warning

./drivers/auxdisplay/lcd2s.c:373:3-8: No need to set .owner here. The core will do it.

Remove .owner field if calls are used which set it automatically

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci

Signed-off-by: Zou Wei <[email protected]>
---
drivers/auxdisplay/lcd2s.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/auxdisplay/lcd2s.c b/drivers/auxdisplay/lcd2s.c
index 3eb7f04..38ba0862 100644
--- a/drivers/auxdisplay/lcd2s.c
+++ b/drivers/auxdisplay/lcd2s.c
@@ -370,7 +370,6 @@ MODULE_DEVICE_TABLE(of, lcd2s_of_table);
static struct i2c_driver lcd2s_i2c_driver = {
.driver = {
.name = "lcd2s",
- .owner = THIS_MODULE,
#ifdef CONFIG_OF
.of_match_table = of_match_ptr(lcd2s_of_table),
#endif
--
2.6.2

2020-11-14 08:51:09

by Miguel Ojeda

Subject: Re: [PATCH -next] auxdisplay: fix platform_no_drv_owner.cocci warning

Hi Zou,

On Sat, Nov 14, 2020 at 9:11 AM Zou Wei <[email protected]> wrote:
>
> ./drivers/auxdisplay/lcd2s.c:373:3-8: No need to set .owner here. The core will do it.

Thanks a lot for the patch. This patch was already submitted by the
kernel test bot, please see
https://lore.kernel.org/lkml/20201111092559.GA67395@c88ae2e89e59/

Cheers,
Miguel