2017-12-13 17:38:09

by Jason Gunthorpe

[permalink] [raw]
Subject: Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call

On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
> The bnxt_qplib_disable_nq() call is redundant as it occurs
> after 'goto fail' and hence it called twice. Remove it.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
> 1 file changed, 1 deletion(-)

Applied to for-next, thanks

Jason


2017-12-19 11:11:36

by Devesh Sharma

[permalink] [raw]
Subject: Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call

However delayed ack but still..thanks for supplying this fix.

Acked-by: Devesh Sharma <[email protected]>


On Wed, Dec 13, 2017 at 11:07 PM, Jason Gunthorpe <[email protected]> wrote:
> On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
>> The bnxt_qplib_disable_nq() call is redundant as it occurs
>> after 'goto fail' and hence it called twice. Remove it.
>>
>> Signed-off-by: Arvind Yadav <[email protected]>
>> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
>> 1 file changed, 1 deletion(-)
>
> Applied to for-next, thanks
>
> Jason

2017-12-19 11:18:05

by Leon Romanovsky

[permalink] [raw]
Subject: Re: RDMA/bnxt_re: Remove redundant bnxt_qplib_disable_nq() call

On Tue, Dec 19, 2017 at 04:40:42PM +0530, Devesh Sharma wrote:
> However delayed ack but still..thanks for supplying this fix.
>
> Acked-by: Devesh Sharma <[email protected]>
>

Devesh,

What should we do in order to stop you to answer in top-posting format?

Thanks


>
> On Wed, Dec 13, 2017 at 11:07 PM, Jason Gunthorpe <[email protected]> wrote:
> > On Tue, Nov 14, 2017 at 06:20:56PM +0530, Arvind Yadav wrote:
> >> The bnxt_qplib_disable_nq() call is redundant as it occurs
> >> after 'goto fail' and hence it called twice. Remove it.
> >>
> >> Signed-off-by: Arvind Yadav <[email protected]>
> >> drivers/infiniband/hw/bnxt_re/qplib_fp.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >
> > Applied to for-next, thanks
> >
> > Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html


Attachments:
(No filename) (952.00 B)
signature.asc (833.00 B)
Download all attachments