Documentation/devicetree/bindings/fpga/fpga-region.txt has an error
regarding the freeze controller bridge, secifically:
compatible = "altr,freeze-bridge";
The compatibility string should be "altr,freeze-bridge-controller"
as set forth in altera-freeze-bridge.txt.
Signed-off-by: Alan Tull <[email protected]>
Reported-by: Dalon Westergreen <[email protected]>
---
Documentation/devicetree/bindings/fpga/fpga-region.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt b/Documentation/devicetree/bindings/fpga/fpga-region.txt
index 6db8aed..90c4469 100644
--- a/Documentation/devicetree/bindings/fpga/fpga-region.txt
+++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt
@@ -415,7 +415,7 @@ DT Overlay contains:
firmware-name = "base.rbf";
fpga-bridge@4400 {
- compatible = "altr,freeze-bridge";
+ compatible = "altr,freeze-bridge-controller";
reg = <0x4400 0x10>;
fpga_region1: fpga-region1 {
@@ -427,7 +427,7 @@ DT Overlay contains:
};
fpga-bridge@4420 {
- compatible = "altr,freeze-bridge";
+ compatible = "altr,freeze-bridge-controller";
reg = <0x4420 0x10>;
fpga_region2: fpga-region2 {
--
2.7.4
On Thu, Sep 6, 2018 at 1:24 PM Moritz Fischer <[email protected]> wrote:
>
> Hi Alan,
>
> looks like it's just the examples, right?
Yes, it's in the examples of use, not the actual freeze bridge
bindings doc that I'm correcting.
> So not sure someone
> would be affected by that, yet?
It's taken two years for anybody to notice and complain about it :) so
the effect has not been very terrible. But it's good to correct it
since it's been noticed.
>
> On Thu, Sep 06, 2018 at 01:01:52PM -0500, Alan Tull wrote:
> > Documentation/devicetree/bindings/fpga/fpga-region.txt has an error
> > regarding the freeze controller bridge, secifically:
> >
> > compatible = "altr,freeze-bridge";
> >
> > The compatibility string should be "altr,freeze-bridge-controller"
> > as set forth in altera-freeze-bridge.txt.
> >
> > Signed-off-by: Alan Tull <[email protected]>
>
> Acked-by: Moritz Fischer <[email protected]>
>
> Cheers,
>
> Moritz
Thanks Moritz!
Alan
Hi Alan,
looks like it's just the examples, right? So not sure someone
would be affected by that, yet?
On Thu, Sep 06, 2018 at 01:01:52PM -0500, Alan Tull wrote:
> Documentation/devicetree/bindings/fpga/fpga-region.txt has an error
> regarding the freeze controller bridge, secifically:
>
> compatible = "altr,freeze-bridge";
>
> The compatibility string should be "altr,freeze-bridge-controller"
> as set forth in altera-freeze-bridge.txt.
>
> Signed-off-by: Alan Tull <[email protected]>
Acked-by: Moritz Fischer <[email protected]>
Cheers,
Moritz
On Thu, Sep 06, 2018 at 01:01:52PM -0500, Alan Tull wrote:
> Documentation/devicetree/bindings/fpga/fpga-region.txt has an error
> regarding the freeze controller bridge, secifically:
>
> compatible = "altr,freeze-bridge";
>
> The compatibility string should be "altr,freeze-bridge-controller"
> as set forth in altera-freeze-bridge.txt.
>
> Signed-off-by: Alan Tull <[email protected]>
> Reported-by: Dalon Westergreen <[email protected]>
> ---
> Documentation/devicetree/bindings/fpga/fpga-region.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied.
Rob