2022-02-11 20:48:27

by Eric Dumazet

Subject: Re: [PATCH] net: Fix build when CONFIG_INET is not enabled

On Fri, Feb 11, 2022 at 8:40 AM Ricardo Ribalda <[email protected]> wrote:
>
> If the kernel is configured with CONFIG_NET, but without CONFIG_INET we
> get the following error when building:
>
> sock.c:(.text+0x4c17): undefined reference to `__sk_defer_free_flush'
>
> Lets move __sk_defer_free_flush to sock.c
>

deja vu ?

commit 48cec899e357cfb92d022a9c0df6bbe72a7f6951
Author: Gal Pressman <[email protected]>
Date: Thu Jan 20 14:34:40 2022 +0200

tcp: Add a stub for sk_defer_free_flush()

When compiling the kernel with CONFIG_INET disabled, the
sk_defer_free_flush() should be defined as a nop.

This resolves the following compilation error:
ld: net/core/sock.o: in function `sk_defer_free_flush':
./include/net/tcp.h:1378: undefined reference to `__sk_defer_free_flush'

Fixes: 79074a72d335 ("net: Flush deferred skb free on socket destroy")
Reported-by: kernel test robot <[email protected]>
Reviewed-by: Tariq Toukan <[email protected]>
Signed-off-by: Gal Pressman <[email protected]>
Reviewed-by: Eric Dumazet <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>

2022-02-11 21:37:02

by Ricardo Ribalda

Subject: Re: [PATCH] net: Fix build when CONFIG_INET is not enabled

Hi Eric

I failed to find that patch. I only searched in linus/master. Please
ignore mine.

Thanks.

On Fri, 11 Feb 2022 at 18:24, Eric Dumazet <[email protected]> wrote:
>
> On Fri, Feb 11, 2022 at 8:40 AM Ricardo Ribalda <[email protected]> wrote:
> >
> > If the kernel is configured with CONFIG_NET, but without CONFIG_INET we
> > get the following error when building:
> >
> > sock.c:(.text+0x4c17): undefined reference to `__sk_defer_free_flush'
> >
> > Lets move __sk_defer_free_flush to sock.c
> >
>
> deja vu ?
>
> commit 48cec899e357cfb92d022a9c0df6bbe72a7f6951
> Author: Gal Pressman <[email protected]>
> Date: Thu Jan 20 14:34:40 2022 +0200
>
> tcp: Add a stub for sk_defer_free_flush()
>
> When compiling the kernel with CONFIG_INET disabled, the
> sk_defer_free_flush() should be defined as a nop.
>
> This resolves the following compilation error:
> ld: net/core/sock.o: in function `sk_defer_free_flush':
> ./include/net/tcp.h:1378: undefined reference to `__sk_defer_free_flush'
>
> Fixes: 79074a72d335 ("net: Flush deferred skb free on socket destroy")
> Reported-by: kernel test robot <[email protected]>
> Reviewed-by: Tariq Toukan <[email protected]>
> Signed-off-by: Gal Pressman <[email protected]>
> Reviewed-by: Eric Dumazet <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]
> Signed-off-by: Jakub Kicinski <[email protected]>



--
Ricardo Ribalda