2020-08-04 11:49:09

by Miaohe Lin

Subject: [PATCH] net: Fix potential out of bound write in skb_try_coalesce()

From: Miaohe Lin <[email protected]>

The head_frag of skb would occupy one extra skb_frag_t. Take it into
account or out of bound write to skb frags may happen.

Signed-off-by: Miaohe Lin <[email protected]>
---
net/core/skbuff.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 8a0c39e4ab0a..b489ba201fac 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -5154,7 +5154,7 @@ bool skb_try_coalesce(struct sk_buff *to, struct sk_buff *from,
unsigned int offset;

if (to_shinfo->nr_frags +
- from_shinfo->nr_frags >= MAX_SKB_FRAGS)
+ from_shinfo->nr_frags + 1 >= MAX_SKB_FRAGS)
return false;

if (skb_head_is_locked(from))
--
2.19.1

2020-08-04 14:36:47

by Eric Dumazet

Subject: Re: [PATCH] net: Fix potential out of bound write in skb_try_coalesce()

On Tue, Aug 4, 2020 at 4:46 AM linmiaohe <[email protected]> wrote:
>
> From: Miaohe Lin <[email protected]>
>
> The head_frag of skb would occupy one extra skb_frag_t. Take it into
> account or out of bound write to skb frags may happen.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Please share a stack trace if this was a real bug spotted in the wild.

I do not believe this patch is correct.

if (A + B >= MAX) is equivalent to if (A + B + 1 > MAX)

Note how the other condition (when there is no bytes in skb header) is coded :

if (A + B > MAX) return false;

In anycase, please always provide a Fixes: tag for any bug fix.

Thanks.

2020-08-06 20:12:35

by Miaohe Lin

Subject: Re: [PATCH] net: Fix potential out of bound write in skb_try_coalesce()

Eric Dumazet <[email protected]> wrote:
>On Tue, Aug 4, 2020 at 4:46 AM linmiaohe <[email protected]> wrote:
>>
>> From: Miaohe Lin <[email protected]>
>>
>> The head_frag of skb would occupy one extra skb_frag_t. Take it into
>> account or out of bound write to skb frags may happen.
>>
>
>Please share a stack trace if this was a real bug spotted in the wild.
>
>I do not believe this patch is correct.
>
>if (A + B >= MAX) is equivalent to if (A + B + 1 > MAX)
>
>Note how the other condition (when there is no bytes in skb header) is coded :
>
>if (A + B > MAX) return false;
>
>In anycase, please always provide a Fixes: tag for any bug fix.
>
>Thanks.

Many thanks for your patient explaination. I compared (A + B >= MAX) with (A + B + 1 > MAX) in skb_gro_receive(),
but I missed the '='. It's my oversight, I'am really sorry about it.

Thanks again.