2021-03-10 06:25:47

by Jiapeng Chong

Subject: [PATCH] selftests/bpf: fix warning comparing pointer to 0

Fix the following coccicheck warning:

./tools/testing/selftests/bpf/progs/test_global_func10.c:17:12-13:
WARNING comparing pointer to 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
tools/testing/selftests/bpf/progs/test_global_func10.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/progs/test_global_func10.c b/tools/testing/selftests/bpf/progs/test_global_func10.c
index 61c2ae9..97b7031 100644
--- a/tools/testing/selftests/bpf/progs/test_global_func10.c
+++ b/tools/testing/selftests/bpf/progs/test_global_func10.c
@@ -14,7 +14,7 @@ struct Big {

__noinline int foo(const struct Big *big)
{
- if (big == 0)
+ if (!big)
return 0;

return bpf_get_prandom_u32() < big->y;
--
1.8.3.1

2021-03-10 09:34:09

by Yauheni Kaliuta

Subject: Re: [PATCH] selftests/bpf: fix warning comparing pointer to 0

On Wed, Mar 10, 2021 at 8:23 AM Jiapeng Chong
<[email protected]> wrote:
>
> Fix the following coccicheck warning:
>
> ./tools/testing/selftests/bpf/progs/test_global_func10.c:17:12-13:
> WARNING comparing pointer to 0.

but it's ok from the C standard point of view

>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> tools/testing/selftests/bpf/progs/test_global_func10.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/test_global_func10.c b/tools/testing/selftests/bpf/progs/test_global_func10.c
> index 61c2ae9..97b7031 100644
> --- a/tools/testing/selftests/bpf/progs/test_global_func10.c
> +++ b/tools/testing/selftests/bpf/progs/test_global_func10.c
> @@ -14,7 +14,7 @@ struct Big {
>
> __noinline int foo(const struct Big *big)
> {
> - if (big == 0)
> + if (!big)
> return 0;
>
> return bpf_get_prandom_u32() < big->y;
> --
> 1.8.3.1
>


--
WBR, Yauheni

2021-03-10 22:01:51

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] selftests/bpf: fix warning comparing pointer to 0

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Wed, 10 Mar 2021 14:22:46 +0800 you wrote:
> Fix the following coccicheck warning:
>
> ./tools/testing/selftests/bpf/progs/test_global_func10.c:17:12-13:
> WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]

Here is the summary with links:
- selftests/bpf: fix warning comparing pointer to 0
https://git.kernel.org/bpf/bpf-next/c/04ea63e34a2e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html