Hi all,
After merging the akpm-current tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
In file included from include/linux/compiler.h:257,
from arch/arm/kernel/asm-offsets.c:10:
include/linux/kasan-checks.h:14:15: error: unknown type name 'bool'
static inline bool __kasan_check_read(const volatile void *p, unsigned int size)
^~~~
include/linux/kasan-checks.h:18:15: error: unknown type name 'bool'
static inline bool __kasan_check_write(const volatile void *p, unsigned int size)
^~~~
include/linux/kasan-checks.h:38:15: error: unknown type name 'bool'
static inline bool kasan_check_read(const volatile void *p, unsigned int size)
^~~~
include/linux/kasan-checks.h:42:15: error: unknown type name 'bool'
static inline bool kasan_check_write(const volatile void *p, unsigned int size)
^~~~
Caused by commit
4bb170e54bbd ("mm/kasan: change kasan_check_{read,write} to return boolean")
I have added the following patch for today:
From: Stephen Rothwell <[email protected]>
Date: Fri, 5 Jul 2019 18:44:55 +1000
Subject: [PATCH] mm/kasan: include types.h for "bool"
Signed-off-by: Stephen Rothwell <[email protected]>
---
include/linux/kasan-checks.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/kasan-checks.h b/include/linux/kasan-checks.h
index 2c7f0b6307b2..53cbf0ae14b5 100644
--- a/include/linux/kasan-checks.h
+++ b/include/linux/kasan-checks.h
@@ -2,6 +2,8 @@
#ifndef _LINUX_KASAN_CHECKS_H
#define _LINUX_KASAN_CHECKS_H
+#include <linux/types.h>
+
/*
* __kasan_check_*: Always available when KASAN is enabled. This may be used
* even in compilation units that selectively disable KASAN, but must use KASAN
--
2.20.1
--
Cheers,
Stephen Rothwell
On Fri, 5 Jul 2019 at 10:49, Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the akpm-current tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> In file included from include/linux/compiler.h:257,
> from arch/arm/kernel/asm-offsets.c:10:
> include/linux/kasan-checks.h:14:15: error: unknown type name 'bool'
> static inline bool __kasan_check_read(const volatile void *p, unsigned int size)
> ^~~~
> include/linux/kasan-checks.h:18:15: error: unknown type name 'bool'
> static inline bool __kasan_check_write(const volatile void *p, unsigned int size)
> ^~~~
> include/linux/kasan-checks.h:38:15: error: unknown type name 'bool'
> static inline bool kasan_check_read(const volatile void *p, unsigned int size)
> ^~~~
> include/linux/kasan-checks.h:42:15: error: unknown type name 'bool'
> static inline bool kasan_check_write(const volatile void *p, unsigned int size)
> ^~~~
>
> Caused by commit
>
> 4bb170e54bbd ("mm/kasan: change kasan_check_{read,write} to return boolean")
>
> I have added the following patch for today:
>
> From: Stephen Rothwell <[email protected]>
> Date: Fri, 5 Jul 2019 18:44:55 +1000
> Subject: [PATCH] mm/kasan: include types.h for "bool"
>
> Signed-off-by: Stephen Rothwell <[email protected]>
> ---
> include/linux/kasan-checks.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/kasan-checks.h b/include/linux/kasan-checks.h
> index 2c7f0b6307b2..53cbf0ae14b5 100644
> --- a/include/linux/kasan-checks.h
> +++ b/include/linux/kasan-checks.h
> @@ -2,6 +2,8 @@
> #ifndef _LINUX_KASAN_CHECKS_H
> #define _LINUX_KASAN_CHECKS_H
>
> +#include <linux/types.h>
> +
> /*
> * __kasan_check_*: Always available when KASAN is enabled. This may be used
> * even in compilation units that selectively disable KASAN, but must use KASAN
> --
> 2.20.1
>
> --
> Cheers,
> Stephen Rothwell
Apologies for the breakage -- thanks for the fix! Shall I send a v+1
or will your patch persist?
Hi Marco,
On Fri, 5 Jul 2019 11:27:58 +0200 Marco Elver <[email protected]> wrote:
>
> Apologies for the breakage -- thanks for the fix! Shall I send a v+1
> or will your patch persist?
I assume Andrew will grab it and squash it into the original patch
before sending it to Linus.
--
Cheers,
Stephen Rothwell