2021-06-29 15:39:00

by Marco Elver

Subject: Re: [PATCH] kfence: skip DMA allocations

On Tue, 29 Jun 2021 at 15:00, Alexander Potapenko <[email protected]> wrote:
[...]
> + /*
> + * Skip DMA allocations. These must reside in the low memory, which we
> + * cannot guarantee.
> + */
> + if (flags & (__GFP_DMA | __GFP_DMA32) ||

I think we want braces around "flags & (...)", so that this becomes:

if ((flags & (...)) ||

> + (s->flags & (SLAB_CACHE_DMA | SLAB_CACHE_DMA32)))
> + return NULL;

Thanks,
-- Marco