2014-07-04 19:17:26

by Fabian Frédérick

Subject: [PATCH 1/1] drm/omap: remove null test before kfree

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: David Airlie <[email protected]>
Cc: David Herrmann <[email protected]>
Cc: Tomi Valkeinen <[email protected]>
Cc: [email protected]
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/gpu/drm/omapdrm/omap_gem.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
index 95dbce2..be0c2e8 100644
--- a/drivers/gpu/drm/omapdrm/omap_gem.c
+++ b/drivers/gpu/drm/omapdrm/omap_gem.c
@@ -1183,9 +1183,7 @@ int omap_gem_op_sync(struct drm_gem_object *obj, enum omap_gem_op op)
}
}
spin_unlock(&sync_lock);
-
- if (waiter)
- kfree(waiter);
+ kfree(waiter);
}
return ret;
}
--
1.9.1

2014-07-06 10:55:37

by David Herrmann

Subject: Re: [PATCH 1/1] drm/omap: remove null test before kfree

Hi

On Fri, Jul 4, 2014 at 9:17 PM, Fabian Frederick <[email protected]> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
>
> Cc: David Airlie <[email protected]>
> Cc: David Herrmann <[email protected]>
> Cc: Tomi Valkeinen <[email protected]>
> Cc: [email protected]
> Signed-off-by: Fabian Frederick <[email protected]>

Reviewed-by: David Herrmann <[email protected]>

Thanks
David

> ---
> drivers/gpu/drm/omapdrm/omap_gem.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c b/drivers/gpu/drm/omapdrm/omap_gem.c
> index 95dbce2..be0c2e8 100644
> --- a/drivers/gpu/drm/omapdrm/omap_gem.c
> +++ b/drivers/gpu/drm/omapdrm/omap_gem.c
> @@ -1183,9 +1183,7 @@ int omap_gem_op_sync(struct drm_gem_object *obj, enum omap_gem_op op)
> }
> }
> spin_unlock(&sync_lock);
> -
> - if (waiter)
> - kfree(waiter);
> + kfree(waiter);
> }
> return ret;
> }
> --
> 1.9.1
>