2015-11-01 11:43:03

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the iommu tree

Hi Joerg,

After merging the iommu tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/iommu/ipmmu-vmsa.c:24:27: fatal error: asm/dma-iommu.h: No such file or directory

Caused by commit

bad78b13e305 ("iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency")

Only arm has the include file ...

I have used the iommu tree from next-20151022 for today.

--
Cheers,
Stephen Rothwell [email protected]


2015-11-01 15:15:05

by Joerg Roedel

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the iommu tree

Hi Stephen,

On Sun, Nov 01, 2015 at 10:42:52PM +1100, Stephen Rothwell wrote:
> After merging the iommu tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/iommu/ipmmu-vmsa.c:24:27: fatal error: asm/dma-iommu.h: No such file or directory
>
> Caused by commit
>
> bad78b13e305 ("iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency")
>
> Only arm has the include file ...
>
> I have used the iommu tree from next-20151022 for today.

Thanks, I reverted the broken commit and will push out an updated tree
soon.


Joerg

2015-11-02 00:15:11

by Magnus Damm

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the iommu tree

Hi Joerg, everyone,

On Mon, Nov 2, 2015 at 12:14 AM, Joerg Roedel <[email protected]> wrote:
> Hi Stephen,
>
> On Sun, Nov 01, 2015 at 10:42:52PM +1100, Stephen Rothwell wrote:
>> After merging the iommu tree, today's linux-next build (x86_64
>> allmodconfig) failed like this:
>>
>> drivers/iommu/ipmmu-vmsa.c:24:27: fatal error: asm/dma-iommu.h: No such file or directory
>>
>> Caused by commit
>>
>> bad78b13e305 ("iommu/ipmmu-vmsa: Drop LPAE Kconfig dependency")
>>
>> Only arm has the include file ...
>>
>> I have used the iommu tree from next-20151022 for today.
>
> Thanks, I reverted the broken commit and will push out an updated tree
> soon.

Thanks for your help and my apologies for the breakage. I did not
expect this patch to enable build on non-ARM platforms but I can now
understand that the LPAE Kconfig bits may have been the last bit
stopping other architectures to build this driver.

I'm currently poking around with this driver on 32/64-bit ARM and
getting rid of those includes from asm/ is for sure on my TODO list.

/ magnus